All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rohit kumar <rohitkr@codeaurora.org>
To: agross@kernel.org, bjorn.andersson@linaro.org,
	lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
	plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
	tiwai@suse.com, srinivas.kandagatla@linaro.org,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rohit kumar <rohitkr@codeaurora.org>
Subject: [PATCH v6 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue
Date: Fri, 14 Aug 2020 16:23:02 +0530	[thread overview]
Message-ID: <1597402388-14112-7-git-send-email-rohitkr@codeaurora.org> (raw)
In-Reply-To: <1597402388-14112-1-git-send-email-rohitkr@codeaurora.org>

i2sctl register value is set to 0 during hw_free(). This
impacts any ongoing concurrent session on the same i2s
port. As trigger() stop already resets enable bit to 0,
there is no need of explicit hw_free. Removing it to
fix the issue.

Fixes: 80beab8e1d86 ("ASoC: qcom: Add LPASS CPU DAI driver")
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/qcom/lpass-cpu.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 6b86f16..5d84f63 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -266,21 +266,6 @@ static int lpass_cpu_daiops_hw_params(struct snd_pcm_substream *substream,
 	return 0;
 }
 
-static int lpass_cpu_daiops_hw_free(struct snd_pcm_substream *substream,
-		struct snd_soc_dai *dai)
-{
-	struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
-	int ret;
-
-	ret = regmap_write(drvdata->lpaif_map,
-			   LPAIF_I2SCTL_REG(drvdata->variant, dai->driver->id),
-			   0);
-	if (ret)
-		dev_err(dai->dev, "error writing to i2sctl reg: %d\n", ret);
-
-	return ret;
-}
-
 static int lpass_cpu_daiops_prepare(struct snd_pcm_substream *substream,
 		struct snd_soc_dai *dai)
 {
@@ -350,7 +335,6 @@ const struct snd_soc_dai_ops asoc_qcom_lpass_cpu_dai_ops = {
 	.startup	= lpass_cpu_daiops_startup,
 	.shutdown	= lpass_cpu_daiops_shutdown,
 	.hw_params	= lpass_cpu_daiops_hw_params,
-	.hw_free	= lpass_cpu_daiops_hw_free,
 	.prepare	= lpass_cpu_daiops_prepare,
 	.trigger	= lpass_cpu_daiops_trigger,
 };
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


  parent reply	other threads:[~2020-08-14 10:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 10:52 [PATCH v6 00/12] ASoC: qcom: Add support for SC7180 lpass variant Rohit kumar
2020-08-14 10:52 ` [PATCH v6 01/12] ASoC: qcom: Add common array to initialize soc based core clocks Rohit kumar
2020-08-14 10:52   ` Rohit kumar
2020-08-14 10:52 ` [PATCH v6 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function Rohit kumar
2020-08-14 10:52 ` [PATCH v6 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev Rohit kumar
2020-08-14 10:52   ` Rohit kumar
2020-08-14 10:53 ` [PATCH v6 04/12] ASoC: qcom: lpass-platform: fix memory leak Rohit kumar
2020-08-14 10:53 ` [PATCH v6 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Rohit kumar
2020-08-14 10:53 ` Rohit kumar [this message]
2020-08-14 10:53 ` [PATCH v6 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node Rohit kumar
2020-08-17 20:35   ` Rob Herring
2020-08-17 20:35     ` Rob Herring
2020-08-14 10:53 ` [PATCH v6 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header Rohit kumar
2020-08-14 10:53   ` Rohit kumar
2020-08-14 10:53 ` [PATCH v6 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar
2020-08-14 10:53   ` Rohit kumar
2020-08-14 10:53 ` [PATCH v6 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource Rohit kumar
2020-08-14 10:53 ` [PATCH v6 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq Rohit kumar
2020-08-14 10:53 ` [PATCH v6 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar
2020-08-17 20:45   ` Rob Herring
2020-08-17 20:45     ` Rob Herring
2020-08-18 16:53 ` [PATCH v6 00/12] ASoC: qcom: Add support for SC7180 lpass variant Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597402388-14112-7-git-send-email-rohitkr@codeaurora.org \
    --to=rohitkr@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.