All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Lee Jones <lee.jones@linaro.org>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH v2 10/11] usb: udc: net2280: convert to readl_poll_timeout_atomic()
Date: Thu, 20 Aug 2020 13:45:48 +0800	[thread overview]
Message-ID: <1597902349-8998-10-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1597902349-8998-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2: add Acked-by Alan
---
 drivers/usb/gadget/udc/net2280.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 7530bd9..f1a21f4 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -52,6 +52,7 @@
 #include <linux/usb/gadget.h>
 #include <linux/prefetch.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -360,18 +361,16 @@ static inline void enable_pciirqenb(struct net2280_ep *ep)
 static int handshake(u32 __iomem *ptr, u32 mask, u32 done, int usec)
 {
 	u32	result;
+	int	ret;
 
-	do {
-		result = readl(ptr);
-		if (result == ~(u32)0)		/* "device unplugged" */
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	ret = readl_poll_timeout_atomic(ptr, result,
+					((result & mask) == done ||
+					 result == U32_MAX),
+					1, usec);
+	if (result == U32_MAX)		/* device unplugged */
+		return -ENODEV;
+
+	return ret;
 }
 
 static const struct usb_ep_ops net2280_ep_ops;
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/11] usb: udc: net2280: convert to readl_poll_timeout_atomic()
Date: Thu, 20 Aug 2020 13:45:48 +0800	[thread overview]
Message-ID: <1597902349-8998-10-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1597902349-8998-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2: add Acked-by Alan
---
 drivers/usb/gadget/udc/net2280.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 7530bd9..f1a21f4 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -52,6 +52,7 @@
 #include <linux/usb/gadget.h>
 #include <linux/prefetch.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -360,18 +361,16 @@ static inline void enable_pciirqenb(struct net2280_ep *ep)
 static int handshake(u32 __iomem *ptr, u32 mask, u32 done, int usec)
 {
 	u32	result;
+	int	ret;
 
-	do {
-		result = readl(ptr);
-		if (result == ~(u32)0)		/* "device unplugged" */
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	ret = readl_poll_timeout_atomic(ptr, result,
+					((result & mask) == done ||
+					 result == U32_MAX),
+					1, usec);
+	if (result == U32_MAX)		/* device unplugged */
+		return -ENODEV;
+
+	return ret;
 }
 
 static const struct usb_ep_ops net2280_ep_ops;
-- 
1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/11] usb: udc: net2280: convert to readl_poll_timeout_atomic()
Date: Thu, 20 Aug 2020 13:45:48 +0800	[thread overview]
Message-ID: <1597902349-8998-10-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1597902349-8998-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2: add Acked-by Alan
---
 drivers/usb/gadget/udc/net2280.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 7530bd9..f1a21f4 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -52,6 +52,7 @@
 #include <linux/usb/gadget.h>
 #include <linux/prefetch.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -360,18 +361,16 @@ static inline void enable_pciirqenb(struct net2280_ep *ep)
 static int handshake(u32 __iomem *ptr, u32 mask, u32 done, int usec)
 {
 	u32	result;
+	int	ret;
 
-	do {
-		result = readl(ptr);
-		if (result == ~(u32)0)		/* "device unplugged" */
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	ret = readl_poll_timeout_atomic(ptr, result,
+					((result & mask) == done ||
+					 result == U32_MAX),
+					1, usec);
+	if (result == U32_MAX)		/* device unplugged */
+		return -ENODEV;
+
+	return ret;
 }
 
 static const struct usb_ep_ops net2280_ep_ops;
-- 
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-08-20  5:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  5:45 [PATCH v2 01/11] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-08-20  5:45 ` Chunfeng Yun
2020-08-20  5:45 ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 02/11] usb: early: ehci-dbgp: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 03/11] usb: pci-quirks: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 04/11] usb: xhci-rcar: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 05/11] usb: oxu210hp-hcd: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 06/11] usb: fotg210-hcd: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 07/11] usb: isp1760-hcd: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 08/11] usb: phy-ulpi-viewport: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 09/11] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20 10:17   ` Sergei Shtylyov
2020-08-20 10:17     ` Sergei Shtylyov
2020-08-20 10:17     ` Sergei Shtylyov
2020-08-21  1:52     ` Chunfeng Yun
2020-08-21  1:52       ` Chunfeng Yun
2020-08-21  1:52       ` Chunfeng Yun
2020-08-20  5:45 ` Chunfeng Yun [this message]
2020-08-20  5:45   ` [PATCH v2 10/11] usb: udc: net2280: " Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45 ` [PATCH v2 11/11] iopoll: update kerneldoc of read_poll_timeout_atomic() Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20  5:45   ` Chunfeng Yun
2020-08-20 10:14   ` Sergei Shtylyov
2020-08-20 10:14     ` Sergei Shtylyov
2020-08-20 10:14     ` Sergei Shtylyov
2020-08-21  1:43     ` Chunfeng Yun
2020-08-21  1:43       ` Chunfeng Yun
2020-08-21  1:43       ` Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597902349-8998-10-git-send-email-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.