All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Felipe Balbi <balbi@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Douglas Anderson <dianders@chromium.org>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Lee Jones <lee.jones@linaro.org>,
	Sumit Garg <sumit.garg@linaro.org>, Jann Horn <jannh@google.com>,
	Arnd Bergmann <arnd@arndb.de>, Jason Yan <yanaijie@huawei.com>,
	Chuhong Yuan <hslester96@gmail.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: [PATCH RESEND v3 07/11] usb: isp1760-hcd: convert to readl_poll_timeout_atomic()
Date: Thu, 10 Sep 2020 16:21:48 +0800	[thread overview]
Message-ID: <1599726112-4439-7-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1599726112-4439-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2~v3: no changes
---
 drivers/usb/isp1760/isp1760-hcd.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index dd74ab7a..33ae656 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -22,6 +22,7 @@
 #include <linux/debugfs.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/mm.h>
 #include <linux/timer.h>
 #include <asm/unaligned.h>
@@ -380,18 +381,15 @@ static int handshake(struct usb_hcd *hcd, u32 reg,
 		      u32 mask, u32 done, int usec)
 {
 	u32 result;
+	int ret;
+
+	ret = readl_poll_timeout_atomic(hcd->regs + reg, result,
+					((result & mask) == done ||
+					 result == U32_MAX), 1, usec);
+	if (result == U32_MAX)
+		return -ENODEV;
 
-	do {
-		result = reg_read32(hcd->regs, reg);
-		if (result == ~0)
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	return ret;
 }
 
 /* reset a non-running (STS_HALT == 1) controller */
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	linux-usb@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Sumit Garg <sumit.garg@linaro.org>,
	linux-kernel@vger.kernel.org, Jann Horn <jannh@google.com>,
	Chuhong Yuan <hslester96@gmail.com>,
	Douglas Anderson <dianders@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Jason Yan <yanaijie@huawei.com>,
	linux-mediatek@lists.infradead.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v3 07/11] usb: isp1760-hcd: convert to readl_poll_timeout_atomic()
Date: Thu, 10 Sep 2020 16:21:48 +0800	[thread overview]
Message-ID: <1599726112-4439-7-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1599726112-4439-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2~v3: no changes
---
 drivers/usb/isp1760/isp1760-hcd.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index dd74ab7a..33ae656 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -22,6 +22,7 @@
 #include <linux/debugfs.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/mm.h>
 #include <linux/timer.h>
 #include <asm/unaligned.h>
@@ -380,18 +381,15 @@ static int handshake(struct usb_hcd *hcd, u32 reg,
 		      u32 mask, u32 done, int usec)
 {
 	u32 result;
+	int ret;
+
+	ret = readl_poll_timeout_atomic(hcd->regs + reg, result,
+					((result & mask) == done ||
+					 result == U32_MAX), 1, usec);
+	if (result == U32_MAX)
+		return -ENODEV;
 
-	do {
-		result = reg_read32(hcd->regs, reg);
-		if (result == ~0)
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	return ret;
 }
 
 /* reset a non-running (STS_HALT == 1) controller */
-- 
1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	linux-usb@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Sumit Garg <sumit.garg@linaro.org>,
	linux-kernel@vger.kernel.org, Jann Horn <jannh@google.com>,
	Chuhong Yuan <hslester96@gmail.com>,
	Douglas Anderson <dianders@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Jason Yan <yanaijie@huawei.com>,
	linux-mediatek@lists.infradead.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v3 07/11] usb: isp1760-hcd: convert to readl_poll_timeout_atomic()
Date: Thu, 10 Sep 2020 16:21:48 +0800	[thread overview]
Message-ID: <1599726112-4439-7-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1599726112-4439-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2~v3: no changes
---
 drivers/usb/isp1760/isp1760-hcd.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index dd74ab7a..33ae656 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -22,6 +22,7 @@
 #include <linux/debugfs.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/mm.h>
 #include <linux/timer.h>
 #include <asm/unaligned.h>
@@ -380,18 +381,15 @@ static int handshake(struct usb_hcd *hcd, u32 reg,
 		      u32 mask, u32 done, int usec)
 {
 	u32 result;
+	int ret;
+
+	ret = readl_poll_timeout_atomic(hcd->regs + reg, result,
+					((result & mask) == done ||
+					 result == U32_MAX), 1, usec);
+	if (result == U32_MAX)
+		return -ENODEV;
 
-	do {
-		result = reg_read32(hcd->regs, reg);
-		if (result == ~0)
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	return ret;
 }
 
 /* reset a non-running (STS_HALT == 1) controller */
-- 
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-09-10  8:31 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:21 [PATCH RESEND v3 01/11] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-09-10  8:21 ` Chunfeng Yun
2020-09-10  8:21 ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 02/11] usb: early: ehci-dbgp: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 03/11] usb: pci-quirks: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 04/11] usb: xhci-rcar: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10 12:56   ` Yoshihiro Shimoda
2020-09-10 12:56     ` Yoshihiro Shimoda
2020-09-10 12:56     ` Yoshihiro Shimoda
2020-09-11  2:21     ` Chunfeng Yun
2020-09-11  2:21       ` Chunfeng Yun
2020-09-11  2:21       ` Chunfeng Yun
2020-09-10 13:12   ` Daniel Thompson
2020-09-10 13:12     ` Daniel Thompson
2020-09-10 13:12     ` Daniel Thompson
2020-09-11  2:33     ` Chunfeng Yun
2020-09-11  2:33       ` Chunfeng Yun
2020-09-11  2:33       ` Chunfeng Yun
2020-09-11  3:13       ` Yoshihiro Shimoda
2020-09-11  3:13         ` Yoshihiro Shimoda
2020-09-11  3:13         ` Yoshihiro Shimoda
2020-09-11  4:12         ` Chunfeng Yun
2020-09-11  4:12           ` Chunfeng Yun
2020-09-11  4:12           ` Chunfeng Yun
2020-09-11  4:57           ` Yoshihiro Shimoda
2020-09-11  4:57             ` Yoshihiro Shimoda
2020-09-11  4:57             ` Yoshihiro Shimoda
2020-09-11 11:46             ` Chunfeng Yun
2020-09-11 11:46               ` Chunfeng Yun
2020-09-11 11:46               ` Chunfeng Yun
2020-09-11  8:34       ` Daniel Thompson
2020-09-11  8:34         ` Daniel Thompson
2020-09-11  8:34         ` Daniel Thompson
2020-09-11  9:27         ` Chunfeng Yun
2020-09-11  9:27           ` Chunfeng Yun
2020-09-11  9:27           ` Chunfeng Yun
2020-09-11  9:48           ` Daniel Thompson
2020-09-11  9:48             ` Daniel Thompson
2020-09-11  9:48             ` Daniel Thompson
2020-09-11  9:58             ` Yoshihiro Shimoda
2020-09-11  9:58               ` Yoshihiro Shimoda
2020-09-11  9:58               ` Yoshihiro Shimoda
2020-09-10  8:21 ` [PATCH RESEND v3 05/11] usb: oxu210hp-hcd: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 06/11] usb: fotg210-hcd: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` Chunfeng Yun [this message]
2020-09-10  8:21   ` [PATCH RESEND v3 07/11] usb: isp1760-hcd: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 08/11] usb: phy-ulpi-viewport: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 09/11] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 10/11] usb: udc: net2280: " Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21 ` [PATCH RESEND v3 11/11] iopoll: update kerneldoc of read_poll_timeout_atomic() Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10  8:21   ` Chunfeng Yun
2020-09-10 10:49 ` [PATCH RESEND v3 01/11] usb: early: convert to readl_poll_timeout_atomic() Jann Horn
2020-09-10 10:49   ` Jann Horn
2020-09-10 10:49   ` Jann Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599726112-4439-7-git-send-email-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavoars@kernel.org \
    --cc=hslester96@gmail.com \
    --cc=jannh@google.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=saurav.girepunje@gmail.com \
    --cc=sumit.garg@linaro.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.