From: xiakaixu1987@gmail.com
To: linux-xfs@vger.kernel.org
Cc: darrick.wong@oracle.com, Kaixu Xia <kaixuxia@tencent.com>
Subject: [PATCH v3 5/7] xfs: remove the redundant crc feature check in xfs_attr3_rmt_verify
Date: Wed, 23 Sep 2020 14:59:16 +0800 [thread overview]
Message-ID: <1600844358-16601-6-git-send-email-kaixuxia@tencent.com> (raw)
In-Reply-To: <1600844358-16601-1-git-send-email-kaixuxia@tencent.com>
From: Kaixu Xia <kaixuxia@tencent.com>
We already check whether the crc feature is enabled before calling
xfs_attr3_rmt_verify(), so remove the redundant feature check in that
function.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/libxfs/xfs_attr_remote.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
index 3f80cede7406..48d8e9caf86f 100644
--- a/fs/xfs/libxfs/xfs_attr_remote.c
+++ b/fs/xfs/libxfs/xfs_attr_remote.c
@@ -96,8 +96,6 @@ xfs_attr3_rmt_verify(
{
struct xfs_attr3_rmt_hdr *rmt = ptr;
- if (!xfs_sb_version_hascrc(&mp->m_sb))
- return __this_address;
if (!xfs_verify_magic(bp, rmt->rm_magic))
return __this_address;
if (!uuid_equal(&rmt->rm_uuid, &mp->m_sb.sb_meta_uuid))
--
2.20.0
next prev parent reply other threads:[~2020-09-23 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 6:59 [PATCH v3 0/7] xfs: random fixes and code cleanup xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 1/7] xfs: remove the unused SYNCHRONIZE macro xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 2/7] xfs: use the existing type definition for di_projid xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 3/7] xfs: remove the unnecessary xfs_dqid_t type cast xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 4/7] xfs: do the assert for all the log done items in xfs_trans_cancel xiakaixu1987
2020-09-23 6:59 ` xiakaixu1987 [this message]
2020-09-23 6:59 ` [PATCH v3 6/7] xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local} xiakaixu1987
2020-09-23 7:08 ` Christoph Hellwig
2020-09-23 6:59 ` [PATCH v3 7/7] xfs: fix some comments xiakaixu1987
2020-09-23 16:28 ` [PATCH v3 0/7] xfs: random fixes and code cleanup Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600844358-16601-6-git-send-email-kaixuxia@tencent.com \
--to=xiakaixu1987@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.