From: Fengfei Xi <fengfei_xi@126.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Fengfei Xi <fengfei_xi@126.com>
Subject: [PATCH] xfs: Drop useless comments
Date: Mon, 2 Nov 2020 08:03:16 +0800 [thread overview]
Message-ID: <1604275396-4565-1-git-send-email-fengfei_xi@126.com> (raw)
The names of functions xfs_buf_get_maps and _xfs_buf_free_pages
can fully express their roles. So their comments are redundant.
We could drop them entirely.
Signed-off-by: Fengfei Xi <fengfei_xi@126.com>
---
fs/xfs/xfs_buf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 4e4cf91..2aeed30 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -197,9 +197,6 @@
return 0;
}
-/*
- * Frees b_pages if it was allocated.
- */
static void
xfs_buf_free_maps(
struct xfs_buf *bp)
@@ -297,9 +294,6 @@
return 0;
}
-/*
- * Frees b_pages if it was allocated.
- */
STATIC void
_xfs_buf_free_pages(
xfs_buf_t *bp)
--
1.9.1
next reply other threads:[~2020-11-02 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 0:03 Fengfei Xi [this message]
2020-11-03 18:50 ` [PATCH] xfs: Drop useless comments Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604275396-4565-1-git-send-email-fengfei_xi@126.com \
--to=fengfei_xi@126.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.