All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Xiang <liu.xiang@zlingsmart.com>
To: linux-mm@kvack.org
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, liuxiang_1999@126.com,
	Liu Xiang <liu.xiang@zlingsmart.com>,
	Pan Jiagen <pan.jiagen@zlingsmart.com>
Subject: [PATCH] mm: hugetlb: fix type of delta parameter in gather_surplus_pages()
Date: Wed, 18 Nov 2020 21:14:01 +0800	[thread overview]
Message-ID: <1605705241-3561-1-git-send-email-liu.xiang@zlingsmart.com> (raw)

On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit
value now.

Reported-by: Ma Chenggong <ma.chenggong@zlingsmart.com>
Signed-off-by: Liu Xiang <liu.xiang@zlingsmart.com>
Signed-off-by: Pan Jiagen <pan.jiagen@zlingsmart.com>
---
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 37f15c3..293b36d 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1943,7 +1943,7 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
  * Increase the hugetlb pool such that it can accommodate a reservation
  * of size 'delta'.
  */
-static int gather_surplus_pages(struct hstate *h, int delta)
+static int gather_surplus_pages(struct hstate *h, long delta)
 	__must_hold(&hugetlb_lock)
 {
 	struct list_head surplus_list;
-- 
1.9.1


             reply	other threads:[~2020-11-18 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 13:14 Liu Xiang [this message]
2020-11-18 18:41 ` [PATCH] mm: hugetlb: fix type of delta parameter in gather_surplus_pages() Mike Kravetz
2020-11-19  9:18   ` 回复：[PATCH] " liu xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1605705241-3561-1-git-send-email-liu.xiang@zlingsmart.com \
    --to=liu.xiang@zlingsmart.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang_1999@126.com \
    --cc=mike.kravetz@oracle.com \
    --cc=pan.jiagen@zlingsmart.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.