From: Jianxin Xiong <jianxin.xiong@intel.com> To: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Jianxin Xiong <jianxin.xiong@intel.com>, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>, Christian Koenig <christian.koenig@amd.com>, Daniel Vetter <daniel.vetter@intel.com> Subject: [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags() Date: Mon, 23 Nov 2020 09:53:04 -0800 [thread overview] Message-ID: <1606153984-104583-6-git-send-email-jianxin.xiong@intel.com> (raw) In-Reply-To: <1606153984-104583-1-git-send-email-jianxin.xiong@intel.com> The filter defintion is wrong and causes get_access_flags() always returning empty list. As the result the MR tests using this function are effectively skipped (but report success). Also fix a typo in the comments. Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> --- tests/utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/utils.py b/tests/utils.py index 0ad7110..eee44b4 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -55,8 +55,8 @@ def filter_illegal_access_flags(element): :param element: A list of access flags to check :return: True if this list is legal, else False """ - if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE: - if e.IBV_ACCESS_LOCAL_WRITE: + if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE in element: + if not e.IBV_ACCESS_LOCAL_WRITE in element: return False return True @@ -69,7 +69,7 @@ def get_access_flags(ctx): added as well. After verifying that the flags selection is legal, it is appended to an array, assuming it wasn't previously appended. - :param ctx: Device Context to check capabilities + :param ctx: Device Coyyntext to check capabilities :param num: Size of initial collection :return: A random legal value for MR flags """ -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Jianxin Xiong <jianxin.xiong@intel.com> To: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>, Doug Ledford <dledford@redhat.com>, Daniel Vetter <daniel.vetter@intel.com>, Christian Koenig <christian.koenig@amd.com>, Jianxin Xiong <jianxin.xiong@intel.com> Subject: [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags() Date: Mon, 23 Nov 2020 09:53:04 -0800 [thread overview] Message-ID: <1606153984-104583-6-git-send-email-jianxin.xiong@intel.com> (raw) In-Reply-To: <1606153984-104583-1-git-send-email-jianxin.xiong@intel.com> The filter defintion is wrong and causes get_access_flags() always returning empty list. As the result the MR tests using this function are effectively skipped (but report success). Also fix a typo in the comments. Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> --- tests/utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/utils.py b/tests/utils.py index 0ad7110..eee44b4 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -55,8 +55,8 @@ def filter_illegal_access_flags(element): :param element: A list of access flags to check :return: True if this list is legal, else False """ - if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE: - if e.IBV_ACCESS_LOCAL_WRITE: + if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE in element: + if not e.IBV_ACCESS_LOCAL_WRITE in element: return False return True @@ -69,7 +69,7 @@ def get_access_flags(ctx): added as well. After verifying that the flags selection is legal, it is appended to an array, assuming it wasn't previously appended. - :param ctx: Device Context to check capabilities + :param ctx: Device Coyyntext to check capabilities :param num: Size of initial collection :return: A random legal value for MR flags """ -- 1.8.3.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-23 17:39 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-23 17:52 [PATCH rdma-core 0/5] Add user space dma-buf support Jianxin Xiong 2020-11-23 17:52 ` Jianxin Xiong 2020-11-23 17:53 ` [PATCH rdma-core 1/5] verbs: Support dma-buf based memory region Jianxin Xiong 2020-11-23 17:53 ` Jianxin Xiong 2020-11-23 18:01 ` Jason Gunthorpe 2020-11-23 18:01 ` Jason Gunthorpe 2020-11-24 10:31 ` Yishai Hadas 2020-11-24 10:31 ` Yishai Hadas 2020-11-24 18:00 ` Xiong, Jianxin 2020-11-24 18:00 ` Xiong, Jianxin 2020-11-23 17:53 ` [PATCH rdma-core 2/5] mlx5: " Jianxin Xiong 2020-11-23 17:53 ` Jianxin Xiong 2020-11-23 18:01 ` Jason Gunthorpe 2020-11-23 18:01 ` Jason Gunthorpe 2020-11-23 19:40 ` Xiong, Jianxin 2020-11-23 19:40 ` Xiong, Jianxin 2020-11-23 17:53 ` [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support Jianxin Xiong 2020-11-23 17:53 ` Jianxin Xiong 2020-11-23 18:05 ` Jason Gunthorpe 2020-11-23 18:05 ` Jason Gunthorpe 2020-11-23 19:48 ` Xiong, Jianxin 2020-11-23 19:48 ` Xiong, Jianxin 2020-11-24 15:16 ` Daniel Vetter 2020-11-24 15:16 ` Daniel Vetter 2020-11-24 15:36 ` Jason Gunthorpe 2020-11-24 15:36 ` Jason Gunthorpe 2020-11-24 16:21 ` Xiong, Jianxin 2020-11-24 16:21 ` Xiong, Jianxin 2020-11-24 18:45 ` Xiong, Jianxin 2020-11-24 18:45 ` Xiong, Jianxin 2020-11-25 10:50 ` Daniel Vetter 2020-11-25 10:50 ` Daniel Vetter 2020-11-25 12:14 ` Jason Gunthorpe 2020-11-25 12:14 ` Jason Gunthorpe 2020-11-25 19:27 ` Xiong, Jianxin 2020-11-25 19:27 ` Xiong, Jianxin 2020-11-26 0:00 ` Jason Gunthorpe 2020-11-26 0:00 ` Jason Gunthorpe 2020-11-26 0:43 ` Xiong, Jianxin 2020-11-26 0:43 ` Xiong, Jianxin 2020-11-23 17:53 ` [PATCH rdma-core 4/5] tests: Add tests for dma-buf based memory regions Jianxin Xiong 2020-11-23 17:53 ` Jianxin Xiong 2020-11-23 17:53 ` Jianxin Xiong [this message] 2020-11-23 17:53 ` [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags() Jianxin Xiong 2020-11-24 20:26 ` John Hubbard 2020-11-24 20:26 ` John Hubbard 2020-11-24 20:43 ` Xiong, Jianxin 2020-11-24 20:43 ` Xiong, Jianxin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1606153984-104583-6-git-send-email-jianxin.xiong@intel.com \ --to=jianxin.xiong@intel.com \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dledford@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jgg@ziepe.ca \ --cc=leon@kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.