All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shengjiu Wang <shengjiu.wang@nxp.com>
To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
	festevam@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret
Date: Wed, 16 Dec 2020 18:44:24 +0800	[thread overview]
Message-ID: <1608115464-18710-1-git-send-email-shengjiu.wang@nxp.com> (raw)

From: shengjiu wang <shengjiu.wang@nxp.com>

When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in))
is true, then goto fail, the uninitialized variable ret will be
returned.

Signed-off-by: shengjiu wang <shengjiu.wang@nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 sound/soc/fsl/imx-hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
index 2c2a76a71940..ede4a9ad1054 100644
--- a/sound/soc/fsl/imx-hdmi.c
+++ b/sound/soc/fsl/imx-hdmi.c
@@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
 
 	if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
 		dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
+		ret = -EINVAL;
 		goto fail;
 	}
 
-- 
2.17.1


             reply	other threads:[~2020-12-16 10:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 10:44 Shengjiu Wang [this message]
2020-12-16 11:06 ` [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret Nicolin Chen
2020-12-16 11:06   ` Nicolin Chen
2020-12-16 11:06   ` Nicolin Chen
2020-12-16 11:26 ` Fabio Estevam
2020-12-16 11:26   ` Fabio Estevam
2020-12-16 11:26   ` Fabio Estevam
2020-12-16 15:52 ` Mark Brown
2020-12-16 15:52   ` Mark Brown
2021-01-12 18:19 ` Nathan Chancellor
2021-01-12 18:19   ` Nathan Chancellor
2021-01-12 18:19   ` Nathan Chancellor
2021-01-12 18:48   ` Mark Brown
2021-01-12 18:48     ` Mark Brown
2021-01-12 18:48     ` Mark Brown
2021-01-12 19:09     ` Nathan Chancellor
2021-01-12 19:09       ` Nathan Chancellor
2021-01-12 19:09       ` Nathan Chancellor
2021-01-12 20:44       ` Mark Brown
2021-01-12 20:44         ` Mark Brown
2021-01-12 20:44         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1608115464-18710-1-git-send-email-shengjiu.wang@nxp.com \
    --to=shengjiu.wang@nxp.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.