From: Bin Meng <bmeng.cn@gmail.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Alistair Francis" <alistair.francis@wdc.com>
Cc: Bin Meng <bin.meng@windriver.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: [PATCH v8 10/10] hw/ssi: imx_spi: Correct tx and rx fifo endianness
Date: Tue, 19 Jan 2021 21:39:06 +0800 [thread overview]
Message-ID: <1611063546-20278-11-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1611063546-20278-1-git-send-email-bmeng.cn@gmail.com>
From: Bin Meng <bin.meng@windriver.com>
The endianness of data exchange between tx and rx fifo is incorrect.
Earlier bytes are supposed to show up on MSB and later bytes on LSB,
ie: in big endian. The manual does not explicitly say this, but the
U-Boot and Linux driver codes have a swap on the data transferred
to tx fifo and from rx fifo.
With this change, U-Boot read from / write to SPI flash tests pass.
=> sf test 1ff000 1000
SPI flash test:
0 erase: 0 ticks, 4096000 KiB/s 32768.000 Mbps
1 check: 3 ticks, 1333 KiB/s 10.664 Mbps
2 write: 235 ticks, 17 KiB/s 0.136 Mbps
3 read: 2 ticks, 2000 KiB/s 16.000 Mbps
Test passed
0 erase: 0 ticks, 4096000 KiB/s 32768.000 Mbps
1 check: 3 ticks, 1333 KiB/s 10.664 Mbps
2 write: 235 ticks, 17 KiB/s 0.136 Mbps
3 read: 2 ticks, 2000 KiB/s 16.000 Mbps
Fixes: c906a3a01582 ("i.MX: Add the Freescale SPI Controller")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
(no changes since v3)
Changes in v3:
- Simplify the tx fifo endianness handling
hw/ssi/imx_spi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
index de0c481..dee7368 100644
--- a/hw/ssi/imx_spi.c
+++ b/hw/ssi/imx_spi.c
@@ -175,7 +175,6 @@ static void imx_spi_flush_txfifo(IMXSPIState *s)
while (!fifo32_is_empty(&s->tx_fifo)) {
int tx_burst = 0;
- int index = 0;
if (s->burst_length <= 0) {
s->burst_length = imx_spi_burst_length(s);
@@ -196,7 +195,7 @@ static void imx_spi_flush_txfifo(IMXSPIState *s)
rx = 0;
while (tx_burst > 0) {
- uint8_t byte = tx & 0xff;
+ uint8_t byte = tx >> (tx_burst - 8);
DPRINTF("writing 0x%02x\n", (uint32_t)byte);
@@ -205,13 +204,11 @@ static void imx_spi_flush_txfifo(IMXSPIState *s)
DPRINTF("0x%02x read\n", (uint32_t)byte);
- tx = tx >> 8;
- rx |= (byte << (index * 8));
+ rx = (rx << 8) | byte;
/* Remove 8 bits from the actual burst */
tx_burst -= 8;
s->burst_length -= 8;
- index++;
}
DPRINTF("data rx:0x%08x\n", rx);
--
2.7.4
next prev parent reply other threads:[~2021-01-19 13:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 13:38 [PATCH v8 00/10] hw/ssi: imx_spi: Fix various bugs in the imx_spi model Bin Meng
2021-01-19 13:38 ` [PATCH v8 01/10] hw/ssi: imx_spi: Use a macro for number of chip selects supported Bin Meng
2021-01-19 13:38 ` [PATCH v8 02/10] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset() Bin Meng
2021-01-28 13:34 ` Peter Maydell
2021-01-19 13:38 ` [PATCH v8 03/10] hw/ssi: imx_spi: Remove pointless variable initialization Bin Meng
2021-01-19 13:39 ` [PATCH v8 04/10] hw/ssi: imx_spi: Rework imx_spi_reset() to keep CONREG register value Bin Meng
2021-01-28 13:43 ` Peter Maydell
2021-01-28 13:46 ` Bin Meng
2021-01-28 13:54 ` Peter Maydell
2021-01-28 14:15 ` Bin Meng
2021-01-28 14:17 ` Philippe Mathieu-Daudé
2021-01-28 14:22 ` Peter Maydell
2021-01-28 14:32 ` Philippe Mathieu-Daudé
2021-01-28 14:41 ` Peter Maydell
2021-01-28 14:49 ` Philippe Mathieu-Daudé
2021-01-28 15:00 ` Bin Meng
2021-01-19 13:39 ` [PATCH v8 05/10] hw/ssi: imx_spi: Rework imx_spi_read() to handle block disabled Bin Meng
2021-01-19 13:39 ` [PATCH v8 06/10] hw/ssi: imx_spi: Rework imx_spi_write() " Bin Meng
2021-01-28 13:34 ` Peter Maydell
2021-01-19 13:39 ` [PATCH v8 07/10] hw/ssi: imx_spi: Disable chip selects when controller is disabled Bin Meng
2021-01-19 13:39 ` [PATCH v8 08/10] hw/ssi: imx_spi: Round up the burst length to be multiple of 8 Bin Meng
2021-01-28 13:50 ` Peter Maydell
2021-01-19 13:39 ` [PATCH v8 09/10] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic Bin Meng
2021-01-19 13:39 ` Bin Meng [this message]
2021-01-28 13:32 ` [PATCH v8 10/10] hw/ssi: imx_spi: Correct tx and rx fifo endianness Peter Maydell
2021-01-22 13:36 ` [PATCH v8 00/10] hw/ssi: imx_spi: Fix various bugs in the imx_spi model Bin Meng
2021-01-28 7:15 ` Bin Meng
2021-01-28 13:51 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611063546-20278-11-git-send-email-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=f4bug@amsat.org \
--cc=jcd@tribudubois.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.