All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alain Volmat <alain.volmat@foss.st.com>
To: <broonie@kernel.org>, <amelie.delaunay@foss.st.com>
Cc: <mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
	<linux-spi@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <fabrice.gasnier@foss.st.com>,
	<alain.volmat@foss.st.com>
Subject: [PATCH v2 1/8] spi: stm32: properly handle 0 byte transfer
Date: Fri, 5 Feb 2021 19:59:25 +0100	[thread overview]
Message-ID: <1612551572-495-2-git-send-email-alain.volmat@foss.st.com> (raw)
In-Reply-To: <1612551572-495-1-git-send-email-alain.volmat@foss.st.com>

On 0 byte transfer request, return straight from the
xfer function after finalizing the transfer.

Fixes: dcbe0d84dfa5 ("spi: add driver for STM32 SPI controller")
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
v2: remove useless spi_finalize_current_transfer

 drivers/spi/spi-stm32.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index db3e305d9ec4..6cdecd1c5ec7 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1657,6 +1657,10 @@ static int stm32_spi_transfer_one(struct spi_master *master,
 	struct stm32_spi *spi = spi_master_get_devdata(master);
 	int ret;
 
+	/* Don't do anything on 0 bytes transfers */
+	if (transfer->len == 0)
+		return 0;
+
 	spi->tx_buf = transfer->tx_buf;
 	spi->rx_buf = transfer->rx_buf;
 	spi->tx_len = spi->tx_buf ? transfer->len : 0;
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Alain Volmat <alain.volmat@foss.st.com>
To: <broonie@kernel.org>, <amelie.delaunay@foss.st.com>
Cc: linux-kernel@vger.kernel.org, alexandre.torgue@foss.st.com,
	fabrice.gasnier@foss.st.com, mcoquelin.stm32@gmail.com,
	alain.volmat@foss.st.com, linux-spi@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/8] spi: stm32: properly handle 0 byte transfer
Date: Fri, 5 Feb 2021 19:59:25 +0100	[thread overview]
Message-ID: <1612551572-495-2-git-send-email-alain.volmat@foss.st.com> (raw)
In-Reply-To: <1612551572-495-1-git-send-email-alain.volmat@foss.st.com>

On 0 byte transfer request, return straight from the
xfer function after finalizing the transfer.

Fixes: dcbe0d84dfa5 ("spi: add driver for STM32 SPI controller")
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
v2: remove useless spi_finalize_current_transfer

 drivers/spi/spi-stm32.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index db3e305d9ec4..6cdecd1c5ec7 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1657,6 +1657,10 @@ static int stm32_spi_transfer_one(struct spi_master *master,
 	struct stm32_spi *spi = spi_master_get_devdata(master);
 	int ret;
 
+	/* Don't do anything on 0 bytes transfers */
+	if (transfer->len == 0)
+		return 0;
+
 	spi->tx_buf = transfer->tx_buf;
 	spi->rx_buf = transfer->rx_buf;
 	spi->tx_len = spi->tx_buf ? transfer->len : 0;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-05 19:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 18:59 [PATCH v2 0/8] spi: stm32: fix and enhancements for spi-stm32 Alain Volmat
2021-02-05 18:59 ` Alain Volmat
2021-02-05 18:59 ` Alain Volmat [this message]
2021-02-05 18:59   ` [PATCH v2 1/8] spi: stm32: properly handle 0 byte transfer Alain Volmat
2021-02-05 18:59 ` [PATCH v2 2/8] spi: stm32: do not mandate cs_gpio Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 3/8] spi: stm32: use bitfield macros Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 4/8] spi: stm32h7: ensure message are smaller than max size Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 5/8] spi: stm32: driver uses reset controller only at init Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 6/8] spi: stm32: defer probe for reset Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 7/8] spi: stm32h7: replace private SPI_1HZ_NS with NSEC_PER_SEC Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 18:59 ` [PATCH v2 8/8] spi: stm32: make spurious and overrun interrupts visible Alain Volmat
2021-02-05 18:59   ` Alain Volmat
2021-02-05 20:16 ` [PATCH v2 0/8] spi: stm32: fix and enhancements for spi-stm32 Mark Brown
2021-02-05 20:16   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612551572-495-2-git-send-email-alain.volmat@foss.st.com \
    --to=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.