All of lore.kernel.org
 help / color / mirror / Atom feed
From: peng.fan@oss.nxp.com
To: ohad@wizery.com, bjorn.andersson@linaro.org,
	mathieu.poirier@linaro.org, o.rempel@pengutronix.de,
	robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	linux-remoteproc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, paul@crapouillou.net,
	matthias.bgg@gmail.com, agross@kernel.org,
	patrice.chotard@st.com, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V10 05/10] remoteproc: imx_rproc: correct err message
Date: Mon,  8 Feb 2021 16:56:06 +0800	[thread overview]
Message-ID: <1612774571-6134-6-git-send-email-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <1612774571-6134-1-git-send-email-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

It is using devm_ioremap, so not devm_ioremap_resource. Correct
the error message and print out sa/size.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/remoteproc/imx_rproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 6603e00bb6f4..2a093cea4997 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 		priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
 						     att->sa, att->size);
 		if (!priv->mem[b].cpu_addr) {
-			dev_err(dev, "devm_ioremap_resource failed\n");
+			dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
 			return -ENOMEM;
 		}
 		priv->mem[b].sys_addr = att->sa;
@@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 
 		priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
 		if (IS_ERR(priv->mem[b].cpu_addr)) {
-			dev_err(dev, "devm_ioremap_resource failed\n");
+			dev_err(dev, "failed to remap %pr\n", &res);
 			err = PTR_ERR(priv->mem[b].cpu_addr);
 			return err;
 		}
-- 
2.30.0


WARNING: multiple messages have this Message-ID (diff)
From: peng.fan@oss.nxp.com
To: ohad@wizery.com, bjorn.andersson@linaro.org,
	mathieu.poirier@linaro.org, o.rempel@pengutronix.de,
	robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: Peng Fan <peng.fan@nxp.com>,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	patrice.chotard@st.com, paul@crapouillou.net, agross@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH V10 05/10] remoteproc: imx_rproc: correct err message
Date: Mon,  8 Feb 2021 16:56:06 +0800	[thread overview]
Message-ID: <1612774571-6134-6-git-send-email-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <1612774571-6134-1-git-send-email-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

It is using devm_ioremap, so not devm_ioremap_resource. Correct
the error message and print out sa/size.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/remoteproc/imx_rproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 6603e00bb6f4..2a093cea4997 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 		priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
 						     att->sa, att->size);
 		if (!priv->mem[b].cpu_addr) {
-			dev_err(dev, "devm_ioremap_resource failed\n");
+			dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
 			return -ENOMEM;
 		}
 		priv->mem[b].sys_addr = att->sa;
@@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 
 		priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
 		if (IS_ERR(priv->mem[b].cpu_addr)) {
-			dev_err(dev, "devm_ioremap_resource failed\n");
+			dev_err(dev, "failed to remap %pr\n", &res);
 			err = PTR_ERR(priv->mem[b].cpu_addr);
 			return err;
 		}
-- 
2.30.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-02-08  9:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08  8:56 [PATCH V10 00/10] remoteproc: imx_rproc: support iMX8MQ/M peng.fan
2021-02-08  8:56 ` peng.fan
2021-02-08  8:56 ` [PATCH V10 01/10] dt-bindings: remoteproc: convert imx rproc bindings to json-schema peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-10 17:37   ` Rob Herring
2021-02-10 17:37     ` Rob Herring
2021-02-13 11:26     ` Peng Fan
2021-02-13 11:26       ` Peng Fan
2021-02-08  8:56 ` [PATCH V10 02/10] dt-bindings: remoteproc: imx_rproc: add i.MX8MQ/M support peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 03/10] remoteproc: introduce is_iomem to rproc_mem_entry peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 04/10] remoteproc: add is_iomem to da_to_va peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-09  6:30   ` kernel test robot
2021-02-09  6:30     ` kernel test robot
2021-02-08  8:56 ` peng.fan [this message]
2021-02-08  8:56   ` [PATCH V10 05/10] remoteproc: imx_rproc: correct err message peng.fan
2021-02-08  8:56 ` [PATCH V10 06/10] remoteproc: imx_rproc: use devm_ioremap peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 08/10] remoteproc: imx_rproc: support i.MX8MQ/M peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 09/10] remoteproc: imx_rproc: ignore mapping vdev regions peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-08  8:56 ` [PATCH V10 10/10] remoteproc: imx_proc: enable virtio/mailbox peng.fan
2021-02-08  8:56   ` peng.fan
2021-02-15 12:34 [PATCH V10 00/10] remoteproc: imx_rproc: support iMX8MQ/M peng.fan
2021-02-15 12:34 ` [PATCH V10 05/10] remoteproc: imx_rproc: correct err message peng.fan
2021-02-15 12:34   ` peng.fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612774571-6134-6-git-send-email-peng.fan@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=ohad@wizery.com \
    --cc=patrice.chotard@st.com \
    --cc=paul@crapouillou.net \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.