From: Yicong Yang <yangyicong@hisilicon.com> To: <gregkh@linuxfoundation.org>, <jdelvare@suse.com>, <linux@roeck-us.net>, <giometti@enneenne.com>, <abbotti@mev.co.uk>, <hsweeten@visionengravers.com>, <kw@linux.com>, <helgaas@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <linux-hwmon@vger.kernel.org>, <devel@driverdev.osuosl.org>, <linux-kbuild@vger.kernel.org>, <masahiroy@kernel.org>, <michal.lkml@markovi.net> Cc: <prime.zeng@huawei.com>, <yangyicong@hisilicon.com>, <linuxarm@openeuler.org> Subject: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag Date: Tue, 9 Feb 2021 19:08:17 +0800 [thread overview] Message-ID: <1612868899-9185-3-git-send-email-yangyicong@hisilicon.com> (raw) In-Reply-To: <1612868899-9185-1-git-send-email-yangyicong@hisilicon.com> From: Junhao He <hejunhao2@hisilicon.com> We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug message in drivers/hwmon, but the DEBUG flag will not pass to the subdirectory. Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG recursively in driver/hwmon. It will be clearer to use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories, and it will avoid omittance of DEBUG define when debug messages added in the subdirectories. Suggested-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Junhao He <hejunhao2@hisilicon.com> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> --- drivers/hwmon/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index 09a86c5..1c0c089 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_PMBUS) += pmbus/ -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG -- 2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Yicong Yang <yangyicong@hisilicon.com> To: <gregkh@linuxfoundation.org>, <jdelvare@suse.com>, <linux@roeck-us.net>, <giometti@enneenne.com>, <abbotti@mev.co.uk>, <hsweeten@visionengravers.com>, <kw@linux.com>, <helgaas@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <linux-hwmon@vger.kernel.org>, <devel@driverdev.osuosl.org>, <linux-kbuild@vger.kernel.org>, <masahiroy@kernel.org>, <michal.lkml@markovi.net> Cc: linuxarm@openeuler.org, prime.zeng@huawei.com, yangyicong@hisilicon.com Subject: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag Date: Tue, 9 Feb 2021 19:08:17 +0800 [thread overview] Message-ID: <1612868899-9185-3-git-send-email-yangyicong@hisilicon.com> (raw) In-Reply-To: <1612868899-9185-1-git-send-email-yangyicong@hisilicon.com> From: Junhao He <hejunhao2@hisilicon.com> We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug message in drivers/hwmon, but the DEBUG flag will not pass to the subdirectory. Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG recursively in driver/hwmon. It will be clearer to use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories, and it will avoid omittance of DEBUG define when debug messages added in the subdirectories. Suggested-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Junhao He <hejunhao2@hisilicon.com> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> --- drivers/hwmon/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index 09a86c5..1c0c089 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_PMBUS) += pmbus/ -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG -- 2.8.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-09 11:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 11:08 [PATCH v2 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang 2021-02-09 11:08 ` Yicong Yang 2021-02-09 11:08 ` [PATCH v2 1/4] driver core: " Yicong Yang 2021-02-09 11:08 ` Yicong Yang 2021-02-09 11:08 ` Yicong Yang [this message] 2021-02-09 11:08 ` [PATCH v2 2/4] hwmon: " Yicong Yang 2021-02-09 15:06 ` Guenter Roeck 2021-02-09 15:06 ` Guenter Roeck 2021-02-10 9:42 ` Yicong Yang 2021-02-10 9:42 ` Yicong Yang 2021-02-09 11:08 ` [PATCH v2 3/4] pps: " Yicong Yang 2021-02-09 11:08 ` Yicong Yang 2021-02-09 12:26 ` Rodolfo Giometti 2021-02-09 12:26 ` Rodolfo Giometti 2021-02-09 11:08 ` [PATCH v2 4/4] staging: comedi: " Yicong Yang 2021-02-09 11:08 ` Yicong Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1612868899-9185-3-git-send-email-yangyicong@hisilicon.com \ --to=yangyicong@hisilicon.com \ --cc=abbotti@mev.co.uk \ --cc=devel@driverdev.osuosl.org \ --cc=giometti@enneenne.com \ --cc=gregkh@linuxfoundation.org \ --cc=helgaas@kernel.org \ --cc=hsweeten@visionengravers.com \ --cc=jdelvare@suse.com \ --cc=kw@linux.com \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=linuxarm@openeuler.org \ --cc=masahiroy@kernel.org \ --cc=michal.lkml@markovi.net \ --cc=prime.zeng@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.