All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCHSET 0/2] fstests: remove _require_no_rtinherit from xfs tests
Date: Tue, 09 Feb 2021 18:56:55 -0800	[thread overview]
Message-ID: <161292581498.3504701.4053663562108530233.stgit@magnolia> (raw)

Hi all,

The _require_no_rtinherit helper is rather bogus -- it disables a test
if the fs was formatted with -drtinherit=1 to avoid failure reports.
The failure reports themselves are usually due to the test requiring
some feature of the data device (e.g. filestreams, AGFL fiddling), and
have nothing to do with realtime at all.  Since we /also/ have a means
for working around rtinherit=1, we should do that instead of skipping
the test.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=remove-no-rtinherit
---
 common/filestreams |    5 +++++
 common/rc          |   10 ----------
 tests/xfs/170      |    1 -
 tests/xfs/171      |    1 -
 tests/xfs/172      |    1 -
 tests/xfs/173      |    1 -
 tests/xfs/174      |    1 -
 tests/xfs/205      |    5 ++++-
 tests/xfs/306      |    5 ++++-
 tests/xfs/318      |    5 ++++-
 tests/xfs/444      |    6 +++++-
 tests/xfs/445      |    5 +++++
 12 files changed, 27 insertions(+), 19 deletions(-)


             reply	other threads:[~2021-02-10  2:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  2:56 Darrick J. Wong [this message]
2021-02-10  2:57 ` [PATCH 1/2] xfs: fix filestreams tests when rtinherit=1 Darrick J. Wong
2021-02-10  2:57 ` [PATCH 2/2] common: remove _require_no_rtinherit Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161292581498.3504701.4053663562108530233.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.