All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Fang <f.fangjian@huawei.com>
To: <linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: <matthias.bgg@gmail.com>, <dan.carpenter@oracle.com>,
	<huangdaode@huawei.com>
Subject: [PATCH] soc: mediatek: pm-domains: fix missing error codes
Date: Mon, 15 Mar 2021 14:47:57 +0800	[thread overview]
Message-ID: <1615790877-55259-1-git-send-email-f.fangjian@huawei.com> (raw)

From: Zihao Tang <tangzihao1@hisilicon.com>

Fixes one smatch warnings:

drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/soc/mediatek/mtk-pm-domains.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
index b7f6976..5778dad 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.c
+++ b/drivers/soc/mediatek/mtk-pm-domains.c
@@ -487,6 +487,7 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
 
 		child_pd = scpsys_add_one_domain(scpsys, child);
 		if (IS_ERR(child_pd)) {
+			ret = PTR_ERR(child_pd);
 			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
 				      "%pOF: failed to get child domain id\n", child);
 			goto err_put_node;
-- 
2.7.4


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Jay Fang <f.fangjian@huawei.com>
To: <linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: <matthias.bgg@gmail.com>, <dan.carpenter@oracle.com>,
	<huangdaode@huawei.com>
Subject: [PATCH] soc: mediatek: pm-domains: fix missing error codes
Date: Mon, 15 Mar 2021 14:47:57 +0800	[thread overview]
Message-ID: <1615790877-55259-1-git-send-email-f.fangjian@huawei.com> (raw)

From: Zihao Tang <tangzihao1@hisilicon.com>

Fixes one smatch warnings:

drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/soc/mediatek/mtk-pm-domains.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
index b7f6976..5778dad 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.c
+++ b/drivers/soc/mediatek/mtk-pm-domains.c
@@ -487,6 +487,7 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
 
 		child_pd = scpsys_add_one_domain(scpsys, child);
 		if (IS_ERR(child_pd)) {
+			ret = PTR_ERR(child_pd);
 			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
 				      "%pOF: failed to get child domain id\n", child);
 			goto err_put_node;
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-03-15  6:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15  6:47 Jay Fang [this message]
2021-03-15  6:47 ` [PATCH] soc: mediatek: pm-domains: fix missing error codes Jay Fang
2021-03-30 10:06 ` Matthias Brugger
2021-03-30 10:06   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1615790877-55259-1-git-send-email-f.fangjian@huawei.com \
    --to=f.fangjian@huawei.com \
    --cc=dan.carpenter@oracle.com \
    --cc=huangdaode@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.