All of lore.kernel.org
 help / color / mirror / Atom feed
From: leirao <lei.rao@intel.com>
To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com,
	jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
	pbonzini@redhat.com, lukasstraub2@web.de
Cc: "Rao, Lei" <lei.rao@intel.com>, qemu-devel@nongnu.org
Subject: [PATCH v3 03/10] Optimize the function of filter_send
Date: Fri, 19 Mar 2021 11:07:41 +0800	[thread overview]
Message-ID: <1616123268-89517-4-git-send-email-lei.rao@intel.com> (raw)
In-Reply-To: <1616123268-89517-1-git-send-email-lei.rao@intel.com>

From: "Rao, Lei" <lei.rao@intel.com>

The iov_size has been calculated in filter_send(). we can directly
return the size.In this way, this is no need to repeat calculations
in filter_redirector_receive_iov();

Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
---
 net/filter-mirror.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index f8e6500..f20240c 100644
--- a/net/filter-mirror.c
+++ b/net/filter-mirror.c
@@ -88,7 +88,7 @@ static int filter_send(MirrorState *s,
         goto err;
     }
 
-    return 0;
+    return size;
 
 err:
     return ret < 0 ? ret : -EIO;
@@ -159,7 +159,7 @@ static ssize_t filter_mirror_receive_iov(NetFilterState *nf,
     int ret;
 
     ret = filter_send(s, iov, iovcnt);
-    if (ret) {
+    if (ret < 0) {
         error_report("filter mirror send failed(%s)", strerror(-ret));
     }
 
@@ -182,10 +182,10 @@ static ssize_t filter_redirector_receive_iov(NetFilterState *nf,
 
     if (qemu_chr_fe_backend_connected(&s->chr_out)) {
         ret = filter_send(s, iov, iovcnt);
-        if (ret) {
+        if (ret < 0) {
             error_report("filter redirector send failed(%s)", strerror(-ret));
         }
-        return iov_size(iov, iovcnt);
+        return ret;
     } else {
         return 0;
     }
-- 
1.8.3.1



  parent reply	other threads:[~2021-03-19  3:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  3:07 [PATCH v3 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-03-19  3:07 ` [PATCH v3 01/10] Remove some duplicate trace code leirao
2021-03-19  3:07 ` [PATCH v3 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-03-19  3:07 ` leirao [this message]
2021-03-19  3:07 ` [PATCH v3 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-03-19  3:07 ` [PATCH v3 05/10] Add a function named packet_new_nocopy for COLO leirao
2021-03-19  3:07 ` [PATCH v3 06/10] Add the function of colo_compare_cleanup leirao
2021-03-19  3:07 ` [PATCH v3 07/10] Reset the auto-converge counter at every checkpoint leirao
2021-03-24 16:40   ` Dr. David Alan Gilbert
2021-03-25  2:32     ` Rao, Lei
2021-03-19  3:07 ` [PATCH v3 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-03-19  3:07 ` [PATCH v3 09/10] Add the function of colo_bitmap_clear_diry leirao
2021-03-19  3:07 ` [PATCH v3 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616123268-89517-4-git-send-email-lei.rao@intel.com \
    --to=lei.rao@intel.com \
    --cc=chen.zhang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=lukasstraub2@web.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.