From: leirao <lei.rao@intel.com>
To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com,
jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
pbonzini@redhat.com, lukasstraub2@web.de
Cc: "Rao, Lei" <lei.rao@intel.com>, qemu-devel@nongnu.org
Subject: [PATCH v4 01/10] Remove some duplicate trace code.
Date: Thu, 25 Mar 2021 10:24:42 +0800 [thread overview]
Message-ID: <1616639091-28279-2-git-send-email-lei.rao@intel.com> (raw)
In-Reply-To: <1616639091-28279-1-git-send-email-lei.rao@intel.com>
From: "Rao, Lei" <lei.rao@intel.com>
There is the same trace code in the colo_compare_packet_payload.
Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
---
net/colo-compare.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 9d1ad99..c142c08 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -590,19 +590,6 @@ static int colo_packet_compare_other(Packet *spkt, Packet *ppkt)
uint16_t offset = ppkt->vnet_hdr_len;
trace_colo_compare_main("compare other");
- if (trace_event_get_state_backends(TRACE_COLO_COMPARE_IP_INFO)) {
- char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];
-
- strcpy(pri_ip_src, inet_ntoa(ppkt->ip->ip_src));
- strcpy(pri_ip_dst, inet_ntoa(ppkt->ip->ip_dst));
- strcpy(sec_ip_src, inet_ntoa(spkt->ip->ip_src));
- strcpy(sec_ip_dst, inet_ntoa(spkt->ip->ip_dst));
-
- trace_colo_compare_ip_info(ppkt->size, pri_ip_src,
- pri_ip_dst, spkt->size,
- sec_ip_src, sec_ip_dst);
- }
-
if (ppkt->size != spkt->size) {
trace_colo_compare_main("Other: payload size of packets are different");
return -1;
--
1.8.3.1
next prev parent reply other threads:[~2021-03-25 2:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 2:24 [PATCH v4 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-03-25 2:24 ` leirao [this message]
2021-03-25 2:24 ` [PATCH v4 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-03-25 2:24 ` [PATCH v4 03/10] Optimize the function of filter_send leirao
2021-03-25 2:24 ` [PATCH v4 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-03-25 2:24 ` [PATCH v4 05/10] Add a function named packet_new_nocopy for COLO leirao
2021-03-25 2:24 ` [PATCH v4 06/10] Add the function of colo_compare_cleanup leirao
2021-03-25 2:24 ` [PATCH v4 07/10] Reset the auto-converge counter at every checkpoint leirao
2021-03-25 2:24 ` [PATCH v4 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-03-29 12:03 ` Dr. David Alan Gilbert
2021-03-25 2:24 ` [PATCH v4 09/10] Add the function of colo_bitmap_clear_diry leirao
2021-03-25 18:07 ` Dr. David Alan Gilbert
2021-03-26 1:45 ` Rao, Lei
2021-03-29 11:31 ` Dr. David Alan Gilbert
2021-04-09 3:52 ` Rao, Lei
2021-03-25 2:24 ` [PATCH v4 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616639091-28279-2-git-send-email-lei.rao@intel.com \
--to=lei.rao@intel.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.