All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 5/5] xfs/49[12]: skip pre-lazysbcount filesystems
Date: Tue, 27 Apr 2021 21:09:24 -0700	[thread overview]
Message-ID: <161958296475.3452351.7075798777673076839.stgit@magnolia> (raw)
In-Reply-To: <161958293466.3452351.14394620932744162301.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

Prior to lazysbcount, the xfs mount code blindly trusted the value of
the fdblocks counter in the primary super, which means that the kernel
doesn't detect the fuzzed fdblocks value at all.  V4 is deprecated and
pre-lazysbcount V4 hasn't been the default for ~14 years, so we'll just
skip these two tests on those old filesystems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/491 |    5 +++++
 tests/xfs/492 |    5 +++++
 2 files changed, 10 insertions(+)


diff --git a/tests/xfs/491 b/tests/xfs/491
index 6420202b..9fd0ab56 100755
--- a/tests/xfs/491
+++ b/tests/xfs/491
@@ -36,6 +36,11 @@ _require_scratch
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
+
+# pre-lazysbcount filesystems blindly trust the primary sb fdblocks
+_check_scratch_xfs_features LAZYSBCOUNT &>/dev/null || \
+	_notrun "filesystem requires lazysbcount"
+
 _scratch_mount >> $seqres.full 2>&1
 echo "test file" > $SCRATCH_MNT/testfile
 
diff --git a/tests/xfs/492 b/tests/xfs/492
index 522def47..c4b087b5 100755
--- a/tests/xfs/492
+++ b/tests/xfs/492
@@ -36,6 +36,11 @@ _require_scratch
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
+
+# pre-lazysbcount filesystems blindly trust the primary sb fdblocks
+_check_scratch_xfs_features LAZYSBCOUNT &>/dev/null || \
+	_notrun "filesystem requires lazysbcount"
+
 _scratch_mount >> $seqres.full 2>&1
 echo "test file" > $SCRATCH_MNT/testfile
 


  parent reply	other threads:[~2021-04-28  4:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  4:08 [PATCHSET 0/5] fstests: miscellaneous fixes Darrick J. Wong
2021-04-28  4:09 ` [PATCH 1/5] xfs/276: remove unnecessary mkfs golden output Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-28  4:09 ` [PATCH 2/5] generic/{094,225}: fix argument to _require_file_block_size_equals_fs_block_size Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-28  4:09 ` [PATCH 3/5] generic/449: always fill up the data device Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-29  0:39     ` Darrick J. Wong
2021-04-28  4:09 ` [PATCH 4/5] xfs/004: don't fail test due to realtime files Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-28  4:09 ` Darrick J. Wong [this message]
2021-04-28 17:47   ` [PATCH 5/5] xfs/49[12]: skip pre-lazysbcount filesystems Brian Foster
2021-04-29  0:44     ` Darrick J. Wong
2021-04-29  1:31   ` [PATCH v1.2 " Darrick J. Wong
2021-04-29 13:30     ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161958296475.3452351.7075798777673076839.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.