All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinhui Huang <huangjh.jy@cn.fujitsu.com>
To: <fstests@vger.kernel.org>
Cc: Jinhui Huang <huangjh.jy@cn.fujitsu.com>
Subject: [PATCH] xfs: Add the appropriate _require helper
Date: Mon, 17 May 2021 11:34:13 +0800	[thread overview]
Message-ID: <1621222453-2824-1-git-send-email-huangjh.jy@cn.fujitsu.com> (raw)

1.xfs/162 uses xfs_db -c 'fuzz' but forgets to check if the feature
is supported. This will cause the case to fail on a system without
fuzz support. so we add _require to check if the fuzz is supported.

2.xfs/495 use _require_scratch_xfs_fuzz_fields to check the features
required by field fuzzing, but some of the features are not used in
this case like xfs_scrub, this will cause the case to skip on a system
without xfs_scrub support, even if the features being uesd are supported.
So we just need to use _require to check the features being used.

Signed-off-by: Jinhui Huang <huangjh.jy@cn.fujitsu.com>
---
 tests/xfs/162 | 2 ++
 tests/xfs/495 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/162 b/tests/xfs/162
index e3257a3..c7c72d1 100755
--- a/tests/xfs/162
+++ b/tests/xfs/162
@@ -31,6 +31,8 @@ _cleanup()
 # real QA test starts here
 _supported_fs xfs
 _require_scratch_nocheck
+_require_populate_commands
+_require_xfs_db_command "fuzz"
 
 rm -f $seqres.full
 
diff --git a/tests/xfs/495 b/tests/xfs/495
index 6292b5e..a3b4fb2 100755
--- a/tests/xfs/495
+++ b/tests/xfs/495
@@ -32,7 +32,9 @@ _cleanup()
 
 # real QA test starts here
 _supported_fs xfs
-_require_scratch_xfs_fuzz_fields
+_require_scratch_nocheck
+_require_populate_commands
+_require_xfs_db_command "fuzz"
 
 echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
-- 
1.8.3.1


             reply	other threads:[~2021-05-17  3:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  3:34 Jinhui Huang [this message]
2021-05-17 15:50 ` [PATCH] xfs: Add the appropriate _require helper Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621222453-2824-1-git-send-email-huangjh.jy@cn.fujitsu.com \
    --to=huangjh.jy@cn.fujitsu.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.