All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net, bhelgaas@google.com
Cc: netdev@vger.kernel.org, linux-pci@vger.kernel.org,
	kuba@kernel.org, gospo@broadcom.com,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: [PATCH] pci: Add ACS quirk for Broadcom NIC.
Date: Fri, 21 May 2021 21:13:17 -0400	[thread overview]
Message-ID: <1621645997-16251-1-git-send-email-michael.chan@broadcom.com> (raw)

From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>

Some Broadcom NICs such as the BCM57414 do not advertise PCI-ACS
capability. All functions on such devices are placed under the same
IOMMU group. Attaching a single PF to a userspace application like
OVS-DPDK using VFIO is not possible, since not all functions in the
IOMMU group are bound to VFIO.

Since peer-to-peer transactions are not possible between PFs on these
devices, it is safe to treat them as fully isolated even though the ACS
capability is not advertised. Fix this issue by adding a PCI quirk for
this chip.

Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/pci/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index dcb229de1acb..cb1628e222df 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4753,6 +4753,8 @@ static const struct pci_dev_acs_enabled {
 	{ PCI_VENDOR_ID_AMPERE, 0xE00A, pci_quirk_xgene_acs },
 	{ PCI_VENDOR_ID_AMPERE, 0xE00B, pci_quirk_xgene_acs },
 	{ PCI_VENDOR_ID_AMPERE, 0xE00C, pci_quirk_xgene_acs },
+	/* Broadcom multi-function device */
+	{ PCI_VENDOR_ID_BROADCOM, 0x16D7, pci_quirk_mf_endpoint_acs },
 	{ PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs },
 	/* Amazon Annapurna Labs */
 	{ PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs },
-- 
2.18.1


             reply	other threads:[~2021-05-22  1:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22  1:13 Michael Chan [this message]
2021-06-02  5:22 ` [PATCH] pci: Add ACS quirk for Broadcom NIC Leon Romanovsky
2021-06-02 21:18 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621645997-16251-1-git-send-email-michael.chan@broadcom.com \
    --to=michael.chan@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=gospo@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.