From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alessandro Zummo <a.zummo@towertech.it>,
"Kim, Milo" <Milo.Kim@ti.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
kernel-janitors@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] rtc: fix snprintf() checking in is_rtc_hctosys()
Date: Tue, 25 May 2021 00:36:24 +0200 [thread overview]
Message-ID: <162189577175.211185.2359785793574104400.b4-ty@bootlin.com> (raw)
In-Reply-To: <YJov/pcGmhLi2pEl@mwanda>
On Tue, 11 May 2021 10:19:26 +0300, Dan Carpenter wrote:
> The scnprintf() function silently truncates the printf() and returns
> the number bytes that it was able to copy (not counting the NUL
> terminator). Thus, the highest value it can return here is
> "NAME_SIZE - 1" and the overflow check is dead code. Fix this by
> using the snprintf() function which returns the number of bytes that
> would have been copied if there was enough space and changing the
> condition from "> NAME_SIZE" to ">= NAME_SIZE".
Applied, thanks!
[1/1] rtc: fix snprintf() checking in is_rtc_hctosys()
commit: 54b909436ede47e0ee07f1765da27ec2efa41e84
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2021-05-24 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:19 [PATCH] rtc: fix snprintf() checking in is_rtc_hctosys() Dan Carpenter
2021-05-24 22:36 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162189577175.211185.2359785793574104400.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=Milo.Kim@ti.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.