All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
	<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <tanhuazhong@huawei.com>,
	<huangguangbin2@huawei.com>
Subject: [PATCH net-next 6/7] net: hdlc: move out assignment in if condition
Date: Tue, 1 Jun 2021 21:23:21 +0800	[thread overview]
Message-ID: <1622553802-19903-7-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1622553802-19903-1-git-send-email-huangguangbin2@huawei.com>

From: Peng Li <lipeng321@huawei.com>

Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c
index fefc732..f48d70e 100644
--- a/drivers/net/wan/hdlc.c
+++ b/drivers/net/wan/hdlc.c
@@ -212,7 +212,8 @@ int hdlc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 	/* Not handled by currently attached protocol (if any) */
 
 	while (proto) {
-		if ((result = proto->ioctl(dev, ifr)) != -EINVAL)
+		result = proto->ioctl(dev, ifr);
+		if (result != -EINVAL)
 			return result;
 		proto = proto->next;
 	}
@@ -363,7 +364,8 @@ static int __init hdlc_module_init(void)
 	int result;
 
 	pr_info("%s\n", version);
-	if ((result = register_netdevice_notifier(&hdlc_notifier)) != 0)
+	result = register_netdevice_notifier(&hdlc_notifier);
+	if (result)
 		return result;
 	dev_add_pack(&hdlc_packet_type);
 	return 0;
-- 
2.8.1


  parent reply	other threads:[~2021-06-01 13:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 13:23 [PATCH net-next 0/7] net: hdlc: clean up some code style issues Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 1/7] net: hdlc: remove redundant blank lines Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 2/7] net: hdlc: add blank line after declarations Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 3/7] net: hdlc: fix an code style issue about "foo* bar" Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 4/7] net: hdlc: fix an code style issue about EXPORT_SYMBOL(foo) Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 5/7] net: hdlc: replace comparison to NULL with "!param" Guangbin Huang
2021-06-01 13:23 ` Guangbin Huang [this message]
2021-06-01 13:23 ` [PATCH net-next 7/7] net: hdlc: add braces {} to all arms of the statement Guangbin Huang
2021-06-02  0:10 ` [PATCH net-next 0/7] net: hdlc: clean up some code style issues patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1622553802-19903-7-git-send-email-huangguangbin2@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=ms@dev.tdt.de \
    --cc=netdev@vger.kernel.org \
    --cc=tanhuazhong@huawei.com \
    --cc=willemb@google.com \
    --cc=xie.he.0141@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.