All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
	<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 05/16] net: farsync: remove redundant initialization for statics
Date: Tue, 8 Jun 2021 16:12:31 +0800	[thread overview]
Message-ID: <1623139962-34847-6-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623139962-34847-1-git-send-email-huangguangbin2@huawei.com>

From: Peng Li <lipeng321@huawei.com>

Should not initialise statics to 0.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/farsync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 8db9c84..7e408d5 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -76,7 +76,7 @@ MODULE_LICENSE("GPL");
 static int fst_txq_low = FST_LOW_WATER_MARK;
 static int fst_txq_high = FST_HIGH_WATER_MARK;
 static int fst_max_reads = 7;
-static int fst_excluded_cards = 0;
+static int fst_excluded_cards;
 static int fst_excluded_list[FST_MAX_CARDS];
 
 module_param(fst_txq_low, int, 0);
@@ -2401,7 +2401,7 @@ static const struct net_device_ops fst_ops = {
 static int
 fst_add_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
-	static int no_of_cards_added = 0;
+	static int no_of_cards_added;
 	struct fst_card_info *card;
 	int err = 0;
 	int i;
-- 
2.8.1


  parent reply	other threads:[~2021-06-08  8:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  8:12 [PATCH net-next 00/16] net: farsync: clean up some code style issues Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 01/16] net: farsync: remove redundant blank lines Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 02/16] net: farsync: add blank line after declarations Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 03/16] net: farsync: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 04/16] net: farsync: move out assignment in if condition Guangbin Huang
2021-06-08  8:12 ` Guangbin Huang [this message]
2021-06-08  8:12 ` [PATCH net-next 06/16] net: farsync: fix the comments style issue Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 07/16] net: farsync: remove trailing whitespaces Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 08/16] net: farsync: code indent use tabs where possible Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 09/16] net: farsync: fix the code style issue about macros Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 10/16] net: farsync: add some required spaces Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 11/16] net: farsync: remove redundant braces {} Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 12/16] net: farsync: remove redundant spaces Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 13/16] net: farsync: remove redundant parentheses Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 14/16] net: farsync: fix the alignment issue Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 15/16] net: farsync: remove redundant return Guangbin Huang
2021-06-08  8:12 ` [PATCH net-next 16/16] net: farsync: replace comparison to NULL with "fst_card_array[i]" Guangbin Huang
2021-06-08 19:10 ` [PATCH net-next 00/16] net: farsync: clean up some code style issues patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1623139962-34847-6-git-send-email-huangguangbin2@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=ms@dev.tdt.de \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=xie.he.0141@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.