From: Manish Narani <manish.narani@xilinx.com> To: <michal.simek@xilinx.com>, <adrian.hunter@intel.com>, <ulf.hansson@linaro.org> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Manish Narani <manish.narani@xilinx.com> Subject: [PATCH 5/7] mmc: host: sdhci-of-arasan: Use appropriate type of division macro Date: Tue, 15 Jun 2021 16:13:55 +0530 [thread overview] Message-ID: <1623753837-21035-6-git-send-email-manish.narani@xilinx.com> (raw) In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> The division macro DIV_ROUND_CLOSEST takes int values as the argument. However the code here uses unsigned int values for this, which is causing the values comparison with 0 as always true. We can use DIV_ROUND_CLOSEST_ULL instead for the same. Addresses-coverity: ("result_independent_of_operands") Signed-off-by: Manish Narani <manish.narani@xilinx.com> --- drivers/mmc/host/sdhci-of-arasan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 98671a3..510d8fc 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -984,7 +984,7 @@ static void sdhci_arasan_update_baseclkfreq(struct sdhci_host *host) struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host); const struct sdhci_arasan_soc_ctl_map *soc_ctl_map = sdhci_arasan->soc_ctl_map; - u32 mhz = DIV_ROUND_CLOSEST(clk_get_rate(pltfm_host->clk), 1000000); + u32 mhz = DIV_ROUND_CLOSEST_ULL(clk_get_rate(pltfm_host->clk), 1000000); /* Having a map is optional */ if (!soc_ctl_map) -- 2.1.1
WARNING: multiple messages have this Message-ID (diff)
From: Manish Narani <manish.narani@xilinx.com> To: <michal.simek@xilinx.com>, <adrian.hunter@intel.com>, <ulf.hansson@linaro.org> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Manish Narani <manish.narani@xilinx.com> Subject: [PATCH 5/7] mmc: host: sdhci-of-arasan: Use appropriate type of division macro Date: Tue, 15 Jun 2021 16:13:55 +0530 [thread overview] Message-ID: <1623753837-21035-6-git-send-email-manish.narani@xilinx.com> (raw) In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> The division macro DIV_ROUND_CLOSEST takes int values as the argument. However the code here uses unsigned int values for this, which is causing the values comparison with 0 as always true. We can use DIV_ROUND_CLOSEST_ULL instead for the same. Addresses-coverity: ("result_independent_of_operands") Signed-off-by: Manish Narani <manish.narani@xilinx.com> --- drivers/mmc/host/sdhci-of-arasan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 98671a3..510d8fc 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -984,7 +984,7 @@ static void sdhci_arasan_update_baseclkfreq(struct sdhci_host *host) struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host); const struct sdhci_arasan_soc_ctl_map *soc_ctl_map = sdhci_arasan->soc_ctl_map; - u32 mhz = DIV_ROUND_CLOSEST(clk_get_rate(pltfm_host->clk), 1000000); + u32 mhz = DIV_ROUND_CLOSEST_ULL(clk_get_rate(pltfm_host->clk), 1000000); /* Having a map is optional */ if (!soc_ctl_map) -- 2.1.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 10:45 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-15 10:43 [PATCH 0/7] sdhci-of-arasan driver updates for ZynqMP platform Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` [PATCH 1/7] mmc: sdhci-of-arasan: Modified SD default speed to 19MHz for ZynqMP Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` [PATCH 2/7] mmc: sdhci-of-arasan: Add "SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12" quirk Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` [PATCH 3/7] mmc: sdhci-of-arasan: Skip Auto tuning for DDR50 mode in ZynqMP platform Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` [PATCH 4/7] mmc: host: sdhci-of-arasan: Check return value of non-void funtions Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` Manish Narani [this message] 2021-06-15 10:43 ` [PATCH 5/7] mmc: host: sdhci-of-arasan: Use appropriate type of division macro Manish Narani 2021-06-15 10:43 ` [PATCH 6/7] mmc: host: sdhci-of-arasan: Modify data type of the clk_phase array Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-15 10:43 ` [PATCH 7/7] mmc: arasan: Fix the issue in reading tap values from DT Manish Narani 2021-06-15 10:43 ` Manish Narani 2021-06-22 15:07 ` [PATCH 0/7] sdhci-of-arasan driver updates for ZynqMP platform Adrian Hunter 2021-06-22 15:07 ` Adrian Hunter 2021-06-29 15:09 ` Ulf Hansson 2021-06-29 15:09 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1623753837-21035-6-git-send-email-manish.narani@xilinx.com \ --to=manish.narani@xilinx.com \ --cc=adrian.hunter@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.