From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 07/15] net: cosa: add braces {} to all arms of the statement
Date: Wed, 16 Jun 2021 15:23:33 +0800 [thread overview]
Message-ID: <1623828221-48349-8-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623828221-48349-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
Braces {} should be used on all arms of this statement.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/cosa.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index c09c079..b3dab61 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -468,11 +468,11 @@ static int cosa_probe(int base, int irq, int dma)
}
/* Test the validity of identification string */
- if (!strncmp(cosa->id_string, "SRP", 3))
+ if (!strncmp(cosa->id_string, "SRP", 3)) {
cosa->type = "srp";
- else if (!strncmp(cosa->id_string, "COSA", 4))
+ } else if (!strncmp(cosa->id_string, "COSA", 4)) {
cosa->type = is_8bit(cosa)? "cosa8": "cosa16";
- else {
+ } else {
/* Print a warning only if we are not autoprobing */
#ifndef COSA_ISA_AUTOPROBE
pr_info("valid signature not found at 0x%x\n", base);
--
2.8.1
next prev parent reply other threads:[~2021-06-16 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:23 [PATCH net-next 00/15] net: cosa: clean up some code style issues Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 01/15] net: cosa: remove redundant blank lines Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 02/15] net: cosa: add blank line after declarations Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 03/15] net: cosa: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 04/15] net: cosa: replace comparison to NULL with "!chan->rx_skb" Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 05/15] net: cosa: move out assignment in if condition Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 06/15] net: cosa: fix the comments style issue Guangbin Huang
2021-06-16 7:23 ` Guangbin Huang [this message]
2021-06-16 7:23 ` [PATCH net-next 08/15] net: cosa: remove redundant braces {} Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 09/15] net: cosa: add necessary () to macro argument Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 10/15] net: cosa: use BIT macro Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 11/15] net: cosa: fix the alignment issue Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 12/15] net: cosa: fix the code style issue about trailing statements Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 13/15] net: cosa: add some required spaces Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 14/15] net: cosa: remove trailing whitespaces Guangbin Huang
2021-06-16 7:23 ` [PATCH net-next 15/15] net: cosa: remove redundant spaces Guangbin Huang
2021-06-16 8:00 ` [PATCH net-next 00/15] net: cosa: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623828221-48349-8-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.