All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64 defconfig breakage (gpio) in next-20130218
Date: Thu, 21 Feb 2013 11:02:15 +0100	[thread overview]
Message-ID: <1634805.kh17mYrJe5@wuerfel> (raw)
In-Reply-To: <20130221093104.GB23442@S2101-09.ap.freescale.net>

On Thursday 21 February 2013 17:31:07 Shawn Guo wrote:
> > 
> > I've bisected this down to 0fa2fd9a0d: "Merge branch 'linusw/devel' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git into
> > gpio/next". Both parent commits build fine.
> > 
> > I've played around a bit, and selecting ARCH_REQUIRE_GPIOLIB in the arm64
> > Kconfig fixes the issue, but I'm unfamilar with gpio{,lib} and I'm not sure
> > that's the best/correct way of solving this.
> 
> Kconfig GENERIC_GPIO is designed as an option defined at architecture
> level and select by platform who knows how gpio driver/API is
> implemented.  The following change should fix the error.
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index f532ce5..aca4a25 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -93,7 +93,7 @@ config IOMMU_HELPER
>         def_bool SWIOTLB
> 
>  config GENERIC_GPIO
> -       def_bool y
> +       bool
> 
>  source "init/Kconfig"

But we have no arm64 platforms that would pick GENERIC_GPIO, it's expected
to come from GPIOLIB anyway. I think the right fix is this:

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index ab4aa54..3fab0db 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -3,6 +3,7 @@ config ARM64
 	select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
 	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
 	select ARCH_WANT_FRAME_POINTERS
+	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_AMBA
 	select ARM_ARCH_TIMER
 	select CLONE_BACKWARDS
@@ -92,9 +93,6 @@ config SWIOTLB
 config IOMMU_HELPER
 	def_bool SWIOTLB
 
-config GENERIC_GPIO
-	def_bool y
-
 source "init/Kconfig"
 
 source "kernel/Kconfig.freezer"


	Arnd

  reply	other threads:[~2013-02-21 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 11:14 arm64 defconfig breakage (gpio) in next-20130218 Mark Rutland
2013-02-21  9:31 ` Shawn Guo
2013-02-21 10:02   ` Arnd Bergmann [this message]
2013-02-21 10:36     ` Grant Likely
2013-02-21 10:44       ` [PATCH] arm64: select ARCH_WANT_OPTIONAL_GPIOLIB Arnd Bergmann
2013-02-21 21:35         ` Linus Walleij
2013-02-22 14:29           ` Grant Likely
     [not found]       ` <1636745.vSza8MrtIn@wuerfel>
2013-02-21 10:46         ` Catalin Marinas
2013-02-22  9:39           ` Mark Rutland
2013-02-21 10:37     ` arm64 defconfig breakage (gpio) in next-20130218 Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1634805.kh17mYrJe5@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.