All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dfaggioli@suse.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 2/2] libtracecmd: use major version as SONAME
Date: Thu, 20 Jan 2022 12:34:20 +0100	[thread overview]
Message-ID: <164267846050.9929.8644383666340215448.stgit@work> (raw)
In-Reply-To: <164267787600.9929.14996075092071019143.stgit@work>

Currently, the SONAME of libtracecmd is libtracecmd.so.0.0.1, which
is legit and overall fine, but slightly inconvenient for packaging.

For other libreries, like libtraceevent and libtracefs, it is set to
libtraceevent.so.1 and libtracefs.so.1. Do the same here

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
Cc: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
 lib/trace-cmd/Makefile |    2 +-
 scripts/utils.mk       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/trace-cmd/Makefile b/lib/trace-cmd/Makefile
index 1760031..c9d36d1 100644
--- a/lib/trace-cmd/Makefile
+++ b/lib/trace-cmd/Makefile
@@ -55,7 +55,7 @@ $(LIBTRACECMD_SHARED_SO): $(LIBTRACECMD_SHARED_VERSION)
 libtracecmd.so: force $(LIBTRACECMD_SHARED_SO)
 
 $(LIBTRACECMD_SHARED): $(OBJS)
-	$(Q)$(call do_compile_shared_library)
+	$(Q)$(call do_compile_shared_library,$(notdir $(LIBTRACECMD_SHARED_VERSION)))
 
 $(bdir)/%.o: %.c
 	$(Q)$(call do_fpic_compile)
diff --git a/scripts/utils.mk b/scripts/utils.mk
index 53b2b07..3fc2d74 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -72,7 +72,7 @@ do_build_static_lib =				\
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
+	$(CC) --shared $^ '-Wl,-soname,$(1),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
 
 do_compile_plugin_obj =				\
 	($(print_plugin_obj_compile)		\



  parent reply	other threads:[~2022-01-20 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 11:34 [PATCH 0/2] (Trivial) README fix and libtracecmd SONAME Dario Faggioli
2022-01-20 11:34 ` [PATCH 1/2] README: remove stale mention to libparsevent Dario Faggioli
2022-01-20 11:34 ` Dario Faggioli [this message]
2022-01-23  2:08 ` [PATCH 0/2] (Trivial) README fix and libtracecmd SONAME Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164267846050.9929.8644383666340215448.stgit@work \
    --to=dfaggioli@suse.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.