All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qing Wang <wangqing@vivo.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Alasdair Kergon" <agk@redhat.com>,
	"Mike Snitzer" <snitzer@redhat.com>,
	dm-devel@redhat.com, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:43 -0800	[thread overview]
Message-ID: <1644890154-64915-7-git-send-email-wangqing@vivo.com> (raw)
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/input/serio/ps2-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 8970b49..7834296
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"RX: timeout, probably we missed an interrupt\n");
 		goto err;
@@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"TX: timeout, probably we missed an interrupt\n");
 		goto err;
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Qing Wang <wangqing@vivo.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Alasdair Kergon" <agk@redhat.com>,
	"Mike Snitzer" <snitzer@redhat.com>,
	dm-devel@redhat.com, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [dm-devel] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:43 -0800	[thread overview]
Message-ID: <1644890154-64915-7-git-send-email-wangqing@vivo.com> (raw)
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/input/serio/ps2-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 8970b49..7834296
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"RX: timeout, probably we missed an interrupt\n");
 		goto err;
@@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"TX: timeout, probably we missed an interrupt\n");
 		goto err;
-- 
2.7.4

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Qing Wang <wangqing@vivo.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Alasdair Kergon" <agk@redhat.com>,
	"Mike Snitzer" <snitzer@redhat.com>,
	dm-devel@redhat.com, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [Intel-gfx] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:43 -0800	[thread overview]
Message-ID: <1644890154-64915-7-git-send-email-wangqing@vivo.com> (raw)
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/input/serio/ps2-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 8970b49..7834296
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"RX: timeout, probably we missed an interrupt\n");
 		goto err;
@@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"TX: timeout, probably we missed an interrupt\n");
 		goto err;
-- 
2.7.4


  parent reply	other threads:[~2022-02-15  1:58 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15  1:55 [PATCH V3 00/13] use time_is_{before,after}_jiffies() instead of open coding it Qing Wang
2022-02-15  1:55 ` [Intel-gfx] [PATCH V3 00/13] use time_is_{before, after}_jiffies() " Qing Wang
2022-02-15  1:55 ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` Qing Wang
2022-02-15  1:55 ` [PATCH V3 1/13] block: xen: use time_is_before_eq_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  9:45   ` Roger Pau Monné
2022-02-15  9:45     ` [dm-devel] " Roger Pau Monné
2022-02-15  9:45     ` Roger Pau Monné
2022-02-15  9:45     ` Roger Pau Monné
2022-02-15  9:45     ` [Intel-gfx] " Roger Pau Monné
2022-02-15  1:55 ` [PATCH V3 2/13] clk: mvebu: " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-17 22:06   ` Stephen Boyd
2022-02-17 22:06     ` [Intel-gfx] " Stephen Boyd
2022-02-17 22:06     ` [dm-devel] " Stephen Boyd
2022-02-15  1:55 ` [PATCH V3 3/13] gpu: drm: i915: use time_is_after_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 4/13] gpu: drm: radeon: use time_is_before_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 5/13] hid: use time_is_after_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  8:47   ` Benjamin Tissoires
2022-02-15  8:47     ` [dm-devel] " Benjamin Tissoires
2022-02-15  8:47     ` Benjamin Tissoires
2022-02-15  8:47     ` [Intel-gfx] " Benjamin Tissoires
2022-02-15  8:47     ` Benjamin Tissoires
     [not found]   ` <AFkA4QAPE2Ol9ndmGVhdHKpl.9.1644914882392.Hmail.wangqing@vivo.com.@PENBTy1od0pKSzV5ZVcrS192THBXVjl0M1RzRWRrMHhDTy1FVHhlSnNYTTJjMTE3SnpOd0BtYWlsLmdtYWlsLmNvbT4=>
2022-02-15  9:03     ` 王擎
2022-02-15  9:03       ` [dm-devel] " 王擎
2022-02-15  9:03       ` [Intel-gfx] " 王擎
2022-02-15  9:03       ` 王擎
2022-02-15  9:03       ` 王擎
2022-02-15  1:55 ` Qing Wang [this message]
2022-02-15  1:55   ` [Intel-gfx] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  8:48   ` Benjamin Tissoires
2022-02-15  8:48     ` [dm-devel] " Benjamin Tissoires
2022-02-15  8:48     ` Benjamin Tissoires
2022-02-15  8:48     ` [Intel-gfx] " Benjamin Tissoires
2022-02-15  8:48     ` Benjamin Tissoires
2022-02-15 22:59   ` Dmitry Torokhov
2022-02-15 22:59     ` Dmitry Torokhov
2022-02-15 22:59     ` Dmitry Torokhov
2022-02-15 22:59     ` [dm-devel] " Dmitry Torokhov
2022-02-15 22:59     ` [Intel-gfx] " Dmitry Torokhov
2022-02-15  1:55 ` [PATCH V3 7/13] md: use time_is_before_jiffies(() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 10/13] md: use time_is_before_eq_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 9/13] media: si21xx: use time_is_before_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 10/13] media: stv0299: " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 11/13] media: tda8083: use time_is_after_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 12/13] media: wl128x: use time_is_before_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang
2022-02-15  1:55 ` [PATCH V3 13/13] media: vivid: use time_is_after_jiffies() " Qing Wang
2022-02-15  1:55   ` [Intel-gfx] " Qing Wang
2022-02-15  1:55   ` [dm-devel] " Qing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1644890154-64915-7-git-send-email-wangqing@vivo.com \
    --to=wangqing@vivo.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=agk@redhat.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=axboe@kernel.dk \
    --cc=benjamin.tissoires@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dm-devel@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jikos@kernel.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=sboyd@kernel.org \
    --cc=snitzer@redhat.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.