From: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
To: adrian.hunter@intel.com, ulf.hansson@linaro.org,
wsa+renesas@sang-engineering.com, shawn.lin@rock-chips.com,
yoshihiro.shimoda.uh@renesas.com, digetx@gmail.com,
quic_asutoshd@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_rampraka@quicinc.com,
quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com,
quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com,
Rajeshwari Ravindra Kamble <c_rkambl@qti.qualcomm.com>
Subject: [PATCH V6 0/5] mmc: add error statistics for eMMC and SD card
Date: Wed, 18 May 2022 12:32:15 +0530 [thread overview]
Message-ID: <1652857340-6040-1-git-send-email-quic_c_sbhanu@quicinc.com> (raw)
From: Rajeshwari Ravindra Kamble <c_rkambl@qti.qualcomm.com>
Changes since V5:
- Considered all error stats enums to set error state.
- Added missed tuning error related code changes which was
missed in patch set V5 as Adrain Hunter pointed.
- Replaced DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
as suggested by Adrain Hunter.
Changes since V4:
- Defined new macro to increment err_stats members when error occured
as suggested by Adrain Hunter.
- Called err_stats members increment function after printing the error
as suggested by Adrain Hunter.
- Considered INDEX and END_BIT errors same as CRC errors as suggested
by Adrain Hunter.
- Removed Null check for host in debug fs functions and Reordered
err_stats declarationas suggested by Adrain Hunter.
- Removed err_state variable stuff and updated err_state debug fs entry
based on the err_stats members state as suggested by Adrain Hunter.
Changes since V3:
- Dropped error stats feature flag as suggested by Adrain Hunter.
- Separated error state related changes in separate patches as
suggested by Adrain Hunter.
[PATCH V4 4/7] : error state debug fs
[PATCH V4 5/7] : error state enable function
[PATCH V4 6/7] : error state enable in error case
- Note: we are enabling error state before calling sdhci_dumpregs
we couldn't add the err state in error stats array as err state
is not error type.
- Corrected Signed-off-by order as suggested by Bjron Andersson.
- Moved error state enable code from sdhci_dumpregs to error
conditions as suggested by Adrain Hunter
Changes since V2:
- Removed userspace error stats clear debug fs entry as suggested
by Adrain Hunter.
- Split patch into 4 patches
[PATCH V3 1/4] : sdhci driver
[PATCH V3 2/4] : debug fs entries
[PATCH V3 3/4] : core driver
[PATCH V3 4/4] : cqhci driver
- Used for loop to print error messages instead of using printf
statements for all error messages as suggested by Adrain Hunter.
- Introduced one flag to enable error stats feature, if any other
client wants to use this feature, they need to enable that flag.
- Moved reset command timeout error statement to card init flow
as suggested by Adrain Hunter.
Changes since V1:
- Removed sysfs entry for eMMC and SD card error statistics and added
debugfs entry as suggested by Adrian Hunter and Ulf Hansson.
Shaik Sajida Bhanu (5):
mmc: core: Capture eMMC and SD card errors
mmc: sdhci: Capture eMMC and SD card errors
mmc: debugfs: Add debug fs entry for mmc driver
mmc: debugfs: Add debug fs error state entry for mmc driver
mmc: cqhci: Capture eMMC and SD card errors
drivers/mmc/core/core.c | 10 +++++-
drivers/mmc/core/debugfs.c | 79 +++++++++++++++++++++++++++++++++++++++++++
drivers/mmc/host/cqhci-core.c | 9 ++++-
drivers/mmc/host/sdhci.c | 59 ++++++++++++++++++++++++--------
drivers/mmc/host/sdhci.h | 3 ++
include/linux/mmc/host.h | 26 ++++++++++++++
include/linux/mmc/mmc.h | 6 ++++
7 files changed, 175 insertions(+), 17 deletions(-)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next reply other threads:[~2022-05-18 7:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 7:02 Shaik Sajida Bhanu [this message]
2022-05-18 7:02 ` [PATCH V6 1/5] mmc: core: Capture eMMC and SD card errors Shaik Sajida Bhanu
2022-05-23 7:14 ` Adrian Hunter
2022-05-24 5:56 ` Sajida Bhanu (Temp)
2022-05-18 7:02 ` [PATCH V6 2/5] mmc: sdhci: " Shaik Sajida Bhanu
2022-05-23 7:14 ` Adrian Hunter
2022-05-24 5:48 ` Sajida Bhanu (Temp)
2022-05-18 7:02 ` [PATCH V6 3/5] mmc: debugfs: Add debug fs entry for mmc driver Shaik Sajida Bhanu
2022-05-23 7:15 ` Adrian Hunter
2022-05-18 7:02 ` [PATCH V6 4/5] mmc: debugfs: Add debug fs error state " Shaik Sajida Bhanu
2022-05-23 7:15 ` Adrian Hunter
2022-05-24 5:19 ` Sajida Bhanu (Temp)
2022-05-18 7:02 ` [PATCH V6 5/5] mmc: cqhci: Capture eMMC and SD card errors Shaik Sajida Bhanu
2022-05-23 7:15 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652857340-6040-1-git-send-email-quic_c_sbhanu@quicinc.com \
--to=quic_c_sbhanu@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=c_rkambl@qti.qualcomm.com \
--cc=digetx@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.