All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Kumar <quic_vivekuma@quicinc.com>
To: <corbet@lwn.net>, <catalin.marinas@arm.com>, <will@kernel.org>,
	<tglx@linutronix.de>, <maz@kernel.org>, <axboe@kernel.dk>,
	<rafael@kernel.org>, <akpm@linux-foundation.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-block@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-mm@kvack.org>
Cc: <len.brown@intel.com>, <pavel@ucw.cz>, <paulmck@kernel.org>,
	<bp@suse.de>, <keescook@chromium.org>, <songmuchun@bytedance.com>,
	<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
	<pasha.tatashin@soleen.com>, <tabba@google.com>,
	<ardb@kernel.org>, <tsoni@quicinc.com>,
	<quic_psodagud@quicinc.com>, <quic_svaddagi@quicinc.com>,
	Vivek Kumar <quic_vivekuma@quicinc.com>,
	Prasanna Kumar <quic_kprasan@quicinc.com>
Subject: [RFC 3/6] block: gendisk: Add a new genhd capability flag
Date: Wed, 18 May 2022 13:18:38 +0530	[thread overview]
Message-ID: <1652860121-24092-4-git-send-email-quic_vivekuma@quicinc.com> (raw)
In-Reply-To: <1652860121-24092-1-git-send-email-quic_vivekuma@quicinc.com>

Add a new genhd capability flag to serialize offsets
for swap partition. This flag is enabled for the gendisk of
the block device which will be used for saving the snapshot
of the hibernation image, based on a kernel parameter
"noswap_randomize". Serializing offset in swap partition
helps in improving hibernation resume time from bootloader.

Signed-off-by: Vivek Kumar <quic_vivekuma@quicinc.com>
Signed-off-by: Prasanna Kumar <quic_kprasan@quicinc.com>
---
 include/linux/blkdev.h | 1 +
 kernel/power/swap.c    | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 1b24c1f..be094e7 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -92,6 +92,7 @@ enum {
 	GENHD_FL_REMOVABLE			= 1 << 0,
 	GENHD_FL_HIDDEN				= 1 << 1,
 	GENHD_FL_NO_PART			= 1 << 2,
+	GENHD_FL_NO_RANDOMIZE			= 1 << 3,
 };
 
 enum {
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 8d5c811..0a40eda 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -1526,6 +1526,9 @@ int swsusp_check(void)
 					    FMODE_READ | FMODE_EXCL, &holder);
 	if (!IS_ERR(hib_resume_bdev)) {
 		set_blocksize(hib_resume_bdev, PAGE_SIZE);
+		if (noswap_randomize)
+			hib_resume_bdev->bd_disk->flags |=
+					GENHD_FL_NO_RANDOMIZE;
 		clear_page(swsusp_header);
 		error = hib_submit_io(REQ_OP_READ, 0,
 					swsusp_resume_block,
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Vivek Kumar <quic_vivekuma@quicinc.com>
To: <corbet@lwn.net>, <catalin.marinas@arm.com>, <will@kernel.org>,
	<tglx@linutronix.de>, <maz@kernel.org>, <axboe@kernel.dk>,
	<rafael@kernel.org>, <akpm@linux-foundation.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-block@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-mm@kvack.org>
Cc: <len.brown@intel.com>, <pavel@ucw.cz>, <paulmck@kernel.org>,
	<bp@suse.de>,  <keescook@chromium.org>,
	<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
	 <damien.lemoal@opensource.wdc.com>, <pasha.tatashin@soleen.com>,
	<tabba@google.com>, <ardb@kernel.org>, <tsoni@quicinc.com>,
	<quic_psodagud@quicinc.com>, <quic_svaddagi@quicinc.com>,
	Vivek Kumar <quic_vivekuma@quicinc.com>,
	Prasanna Kumar <quic_kprasan@quicinc.com>
Subject: [RFC 3/6] block: gendisk: Add a new genhd capability flag
Date: Wed, 18 May 2022 13:18:38 +0530	[thread overview]
Message-ID: <1652860121-24092-4-git-send-email-quic_vivekuma@quicinc.com> (raw)
In-Reply-To: <1652860121-24092-1-git-send-email-quic_vivekuma@quicinc.com>

Add a new genhd capability flag to serialize offsets
for swap partition. This flag is enabled for the gendisk of
the block device which will be used for saving the snapshot
of the hibernation image, based on a kernel parameter
"noswap_randomize". Serializing offset in swap partition
helps in improving hibernation resume time from bootloader.

Signed-off-by: Vivek Kumar <quic_vivekuma@quicinc.com>
Signed-off-by: Prasanna Kumar <quic_kprasan@quicinc.com>
---
 include/linux/blkdev.h | 1 +
 kernel/power/swap.c    | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 1b24c1f..be094e7 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -92,6 +92,7 @@ enum {
 	GENHD_FL_REMOVABLE			= 1 << 0,
 	GENHD_FL_HIDDEN				= 1 << 1,
 	GENHD_FL_NO_PART			= 1 << 2,
+	GENHD_FL_NO_RANDOMIZE			= 1 << 3,
 };
 
 enum {
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 8d5c811..0a40eda 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -1526,6 +1526,9 @@ int swsusp_check(void)
 					    FMODE_READ | FMODE_EXCL, &holder);
 	if (!IS_ERR(hib_resume_bdev)) {
 		set_blocksize(hib_resume_bdev, PAGE_SIZE);
+		if (noswap_randomize)
+			hib_resume_bdev->bd_disk->flags |=
+					GENHD_FL_NO_RANDOMIZE;
 		clear_page(swsusp_header);
 		error = hib_submit_io(REQ_OP_READ, 0,
 					swsusp_resume_block,
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-18  7:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  7:48 [RFC 0/6] Bootloader based hibernation Vivek Kumar
2022-05-18  7:48 ` Vivek Kumar
2022-05-18  7:48 ` [RFC 1/6] arm64: hibernate: Introduce new entry point to kernel Vivek Kumar
2022-05-18  7:48   ` Vivek Kumar
2022-05-19 15:27   ` Marc Zyngier
2022-05-19 15:27     ` Marc Zyngier
2022-05-18  7:48 ` [RFC 2/6] PM: Hibernate: Add option to disable disk offset randomization Vivek Kumar
2022-05-18  7:48   ` Vivek Kumar
2022-05-18 12:19   ` Andrew Lunn
2022-05-18 12:19     ` Andrew Lunn
2022-05-18 13:00   ` Christoph Hellwig
2022-05-18 13:00     ` Christoph Hellwig
2022-05-23 20:49   ` Randy Dunlap
2022-05-23 20:49     ` Randy Dunlap
2022-05-18  7:48 ` Vivek Kumar [this message]
2022-05-18  7:48   ` [RFC 3/6] block: gendisk: Add a new genhd capability flag Vivek Kumar
2022-05-18  8:08   ` Christoph Hellwig
2022-05-18  8:08     ` Christoph Hellwig
2022-05-18  7:48 ` [RFC 4/6] mm: swap: Add randomization check for swapon/off calls Vivek Kumar
2022-05-18  7:48   ` Vivek Kumar
2022-05-18 12:27   ` Andrew Lunn
2022-05-18 12:27     ` Andrew Lunn
2022-05-18  7:48 ` [RFC 5/6] Hibernate: Add check for pte_valid in saveable page Vivek Kumar
2022-05-18  7:48   ` Vivek Kumar
2022-05-18 13:09   ` Christoph Hellwig
2022-05-18 13:09     ` Christoph Hellwig
2022-05-18  7:48 ` [RFC 6/6] irqchip/gic-v3: Re-init GIC hardware upon hibernation restore Vivek Kumar
2022-05-18  7:48   ` Vivek Kumar
2022-05-19  7:59   ` Marc Zyngier
2022-05-19  7:59     ` Marc Zyngier
2022-05-18 16:55 ` [RFC 0/6] Bootloader based hibernation Pasha Tatashin
2022-05-18 16:55   ` Pasha Tatashin
2022-05-20 16:43 ` Mark Rutland
2022-05-20 16:43   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1652860121-24092-4-git-send-email-quic_vivekuma@quicinc.com \
    --to=quic_vivekuma@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bp@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=keescook@chromium.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulmck@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=quic_kprasan@quicinc.com \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_svaddagi@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=songmuchun@bytedance.com \
    --cc=tabba@google.com \
    --cc=tglx@linutronix.de \
    --cc=tsoni@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.