All of lore.kernel.org
 help / color / mirror / Atom feed
From: cy_huang <u0084500@gmail.com>
To: broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: oder_chiou@realtek.com, lgirdwood@gmail.com,
	ritchie_hsieh@richtek.com, allen_lin@richtek.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	ChiYuan Huang <cy_huang@richtek.com>
Subject: [PATCH 1/2] ASoC: rt9120: Fix 3byte read, valule offset typo
Date: Thu, 19 May 2022 10:13:37 +0800	[thread overview]
Message-ID: <1652926418-8519-2-git-send-email-u0084500@gmail.com> (raw)
In-Reply-To: <1652926418-8519-1-git-send-email-u0084500@gmail.com>

From: ChiYuan Huang <cy_huang@richtek.com>

For RG 3byte read, the value order is  offset [0], [1], and [2].

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
 sound/soc/codecs/rt9120.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt9120.c b/sound/soc/codecs/rt9120.c
index cdf8ad2..94d42be 100644
--- a/sound/soc/codecs/rt9120.c
+++ b/sound/soc/codecs/rt9120.c
@@ -372,7 +372,7 @@ static int rt9120_reg_read(void *context, unsigned int reg, unsigned int *val)
 		*val = be32_to_cpup((__be32 *)raw);
 		break;
 	case 3:
-		*val = raw[0] << 16 | raw[1] << 8 | raw[0];
+		*val = raw[0] << 16 | raw[1] << 8 | raw[2];
 		break;
 	case 2:
 		*val = be16_to_cpup((__be16 *)raw);
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: cy_huang <u0084500@gmail.com>
To: broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
	ritchie_hsieh@richtek.com, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org,
	ChiYuan Huang <cy_huang@richtek.com>,
	allen_lin@richtek.com
Subject: [PATCH 1/2] ASoC: rt9120: Fix 3byte read, valule offset typo
Date: Thu, 19 May 2022 10:13:37 +0800	[thread overview]
Message-ID: <1652926418-8519-2-git-send-email-u0084500@gmail.com> (raw)
In-Reply-To: <1652926418-8519-1-git-send-email-u0084500@gmail.com>

From: ChiYuan Huang <cy_huang@richtek.com>

For RG 3byte read, the value order is  offset [0], [1], and [2].

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
 sound/soc/codecs/rt9120.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt9120.c b/sound/soc/codecs/rt9120.c
index cdf8ad2..94d42be 100644
--- a/sound/soc/codecs/rt9120.c
+++ b/sound/soc/codecs/rt9120.c
@@ -372,7 +372,7 @@ static int rt9120_reg_read(void *context, unsigned int reg, unsigned int *val)
 		*val = be32_to_cpup((__be32 *)raw);
 		break;
 	case 3:
-		*val = raw[0] << 16 | raw[1] << 8 | raw[0];
+		*val = raw[0] << 16 | raw[1] << 8 | raw[2];
 		break;
 	case 2:
 		*val = be16_to_cpup((__be16 *)raw);
-- 
2.7.4


  reply	other threads:[~2022-05-19  2:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  2:13 [PATCH 0/2] ASoC: rt9120: Fix 3byte read logic and optimize 'PWDN' control cy_huang
2022-05-19  2:13 ` cy_huang
2022-05-19  2:13 ` cy_huang [this message]
2022-05-19  2:13   ` [PATCH 1/2] ASoC: rt9120: Fix 3byte read, valule offset typo cy_huang
2022-05-19  2:13 ` [PATCH 2/2] ASoC: rt9120: Use pm_runtime and regcache to optimize 'pwdnn' logic cy_huang
2022-05-19  2:13   ` cy_huang
2022-05-20 11:18 ` [PATCH 0/2] ASoC: rt9120: Fix 3byte read logic and optimize 'PWDN' control Mark Brown
2022-05-20 11:18   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1652926418-8519-2-git-send-email-u0084500@gmail.com \
    --to=u0084500@gmail.com \
    --cc=allen_lin@richtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=ritchie_hsieh@richtek.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.