All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
To: <michal.simek@xilinx.com>, <michal.simek@amd.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<git@amd.com>
Cc: Raviteja Narayanam <raviteja.narayanam@xilinx.com>,
	Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
Subject: [PATCH 08/12] i2c: xiic: Remove interrupt enable/disable in Rx path
Date: Fri, 24 Jun 2022 17:35:23 +0530	[thread overview]
Message-ID: <1656072327-13628-9-git-send-email-manikanta.guntupalli@xilinx.com> (raw)
In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com>

From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>

As the 'DYNAMIC_MODE_READ_BROKEN_BIT' quirk is added in the driver,
we no longer enter dynamic mode for the effected IP versions.
So, remove local_irq_save/local_irq_restore APIs from driver.

Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
---
 drivers/i2c/busses/i2c-xiic.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 74cd50478694..720aa671f74b 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -776,7 +776,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 	u16 rx_watermark;
 	u8 cr = 0, rfd_set = 0;
 	struct i2c_msg *msg = i2c->rx_msg = i2c->tx_msg;
-	unsigned long flags;
 
 	dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n",
 		__func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET),
@@ -808,7 +807,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 
 		xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, bytes);
 
-		local_irq_save(flags);
 		if (!(msg->flags & I2C_M_NOSTART))
 			/* write the address */
 			xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET,
@@ -822,7 +820,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 		val |= msg->len;
 
 		xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val);
-		local_irq_restore(flags);
 	} else {
 		/*
 		 * If previous message is Tx, make sure that Tx FIFO is empty
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
To: <michal.simek@xilinx.com>, <michal.simek@amd.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<git@amd.com>
Cc: Raviteja Narayanam <raviteja.narayanam@xilinx.com>,
	Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
Subject: [PATCH 08/12] i2c: xiic: Remove interrupt enable/disable in Rx path
Date: Fri, 24 Jun 2022 17:35:23 +0530	[thread overview]
Message-ID: <1656072327-13628-9-git-send-email-manikanta.guntupalli@xilinx.com> (raw)
In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com>

From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>

As the 'DYNAMIC_MODE_READ_BROKEN_BIT' quirk is added in the driver,
we no longer enter dynamic mode for the effected IP versions.
So, remove local_irq_save/local_irq_restore APIs from driver.

Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
---
 drivers/i2c/busses/i2c-xiic.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 74cd50478694..720aa671f74b 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -776,7 +776,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 	u16 rx_watermark;
 	u8 cr = 0, rfd_set = 0;
 	struct i2c_msg *msg = i2c->rx_msg = i2c->tx_msg;
-	unsigned long flags;
 
 	dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n",
 		__func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET),
@@ -808,7 +807,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 
 		xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, bytes);
 
-		local_irq_save(flags);
 		if (!(msg->flags & I2C_M_NOSTART))
 			/* write the address */
 			xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET,
@@ -822,7 +820,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
 		val |= msg->len;
 
 		xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val);
-		local_irq_restore(flags);
 	} else {
 		/*
 		 * If previous message is Tx, make sure that Tx FIFO is empty
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-24 12:07 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 12:05 [PATCH 00/12] i2c: xiic: Added Standard mode and SMBus Manikanta Guntupalli
2022-06-24 12:05 ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 01/12] i2c: xiic: Add standard mode support for > 255 byte read transfers Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-29 12:18   ` Krzysztof Adamski
2022-06-29 12:18     ` Krzysztof Adamski
2022-07-13  7:54     ` Guntupalli, Manikanta
2022-07-13  7:54       ` Guntupalli, Manikanta
2022-07-20 10:26       ` Krzysztof Adamski
2022-07-20 10:26         ` Krzysztof Adamski
2022-07-26 10:35         ` Guntupalli, Manikanta
2022-07-26 10:35           ` Guntupalli, Manikanta
2022-06-24 12:05 ` [PATCH 02/12] i2c: xiic: Enter standard mode only " Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-29 12:21   ` Krzysztof Adamski
2022-06-29 12:21     ` Krzysztof Adamski
2022-06-30  8:06     ` Guntupalli, Manikanta
2022-06-30  8:06       ` Guntupalli, Manikanta
2022-06-24 12:05 ` [PATCH 03/12] i2c: xiic: Fix Rx and Tx paths in standard mode repeated start Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 04/12] i2c: xiic: Add wait for FIFO empty in send_tx Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 05/12] i2c: xiic: Use 'nmsgs' variable instead of repeated_start Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 06/12] i2c: xiic: Add smbus_block_read functionality Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-29 12:25   ` Krzysztof Adamski
2022-06-29 12:25     ` Krzysztof Adamski
2022-06-24 12:05 ` [PATCH 07/12] i2c: xiic: Switch to Xiic standard mode for i2c-read Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` Manikanta Guntupalli [this message]
2022-06-24 12:05   ` [PATCH 08/12] i2c: xiic: Remove interrupt enable/disable in Rx path Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 09/12] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 10/12] i2c: xiic: Update compatible with new IP version Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 11/12] i2c: xiic: Add SCL frequency configuration support Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 12/12] i2c: xiic: Correct the BNB interrupt enable sequence Manikanta Guntupalli
2022-06-24 12:05   ` Manikanta Guntupalli
2022-06-29 13:13   ` Krzysztof Adamski
2022-06-29 13:13     ` Krzysztof Adamski
2022-07-13  8:02     ` Guntupalli, Manikanta
2022-07-13  8:02       ` Guntupalli, Manikanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1656072327-13628-9-git-send-email-manikanta.guntupalli@xilinx.com \
    --to=manikanta.guntupalli@xilinx.com \
    --cc=git@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=michal.simek@xilinx.com \
    --cc=raviteja.narayanam@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.