From: Yang Xu <xuyang2018.jy@fujitsu.com>
To: <fstests@vger.kernel.org>
Cc: Yang Xu <xuyang2018.jy@fujitsu.com>
Subject: [PATCH v3 1/2] xfs/270: Fix syntax error
Date: Tue, 19 Jul 2022 16:31:12 +0800 [thread overview]
Message-ID: <1658219473-2310-1-git-send-email-xuyang2018.jy@fujitsu.com> (raw)
In-Reply-To: <20220719051310.mptogjydytz233n4@zlang-mailbox>
Without xfsprogs commit
f4afdcb0a ("xfs_db: clean up the salvage read callsites in set_cur()"),
this case will fail as below:
+/var/lib/xfstests/tests/xfs/270: line 51: [: !=: unary operator expected
With this xfsprogs bug, xfs_db can't get new_ro_compat value, so report
this bash syntax error.
Fix this and add a helper output for xfsprogs bug.
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
tests/xfs/270 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/270 b/tests/xfs/270
index b740c379..4954e943 100755
--- a/tests/xfs/270
+++ b/tests/xfs/270
@@ -47,9 +47,12 @@ _scratch_xfs_set_metadata_field "features_ro_compat" "$ro_compat" "sb 0" \
new_ro_compat=$(_scratch_xfs_get_metadata_field "features_ro_compat" "sb 0" \
2>/dev/null)
-# verify the new ro_compat field is correct.
-if [ $new_ro_compat != $ro_compat ]; then
+# verify the new ro_compat field is correct. Without xfsprogs commit
+# f4afdcb0ad ("xfs_db: clean up the salvage read callsites in set_cur()"),
+# we can't get new_ro_compat value.
+if [ "$new_ro_compat" != "$ro_compat" ]; then
echo "Unable to set new features_ro_compat. Wanted $ro_compat, got $new_ro_compat"
+ echo "May hit a known xfsprog bug"
fi
# rw mount with unknown ro-compat feature should fail
--
2.23.0
next prev parent reply other threads:[~2022-07-19 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 9:20 [PATCH v2 1/2] xfs/270: Fix syntax error Yang Xu
2022-07-05 9:20 ` [PATCH v2 2/2] xfs/191: test xfs_db get corrupted value Yang Xu
2022-07-19 5:21 ` Zorro Lang
2022-07-19 6:59 ` xuyang2018.jy
2022-07-19 2:13 ` [PATCH v2 1/2] xfs/270: Fix syntax error xuyang2018.jy
2022-07-19 5:13 ` Zorro Lang
2022-07-19 8:31 ` Yang Xu [this message]
2022-07-19 8:31 ` [PATCH v3 2/2] xfs/533: test xfs_db whether still can get corrupted field value Yang Xu
2022-07-19 14:47 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658219473-2310-1-git-send-email-xuyang2018.jy@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.