From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: neilb@suse.de
Subject: [PATCH v5 00/13] A course change, for sure
Date: Mon, 24 Oct 2022 18:36:53 -0400 [thread overview]
Message-ID: <166664935937.50761.7812494396457965637.stgit@klimt.1015granger.net> (raw)
I'm proposing this series for v6.2 (for-next).
For quite some time, we've been encouraged to disable filecache
garbage collection for NFSv4 files, and I think I found a surgical
way to do just that. That is presented in "NFSD: Add an NFSD_FILE_GC
flag to enable nfsd_file garbage collection".
The other major change in this set is reworking the file_hashtbl to
resize itself dynamically. This reduces the average size of its
bucket chains, greatly speeding up hash insertion, which holds the
state_lock.
The current rhashtable changes are failing some tests, so expect
another revision of this series soon.
Comments and opinions are welcome.
Changes since v4:
- Addressed some comments in the GC patch; more to come
- Split clean-ups out of the rhashtable patch, reordered the series
- Removed state_lock from the rhashtable helpers
Changes since v3:
- the new filehandle alias check was still not right
Changes since v2:
- Converted nfs4_file_rhashtbl to nfs4_file_rhltable
- Addressed most or all other review comments
Changes since RFC:
- checking nfs4_files for inode aliases is now done only on hash
insertion
- the nfs4_file reference count is now bumped only while the RCU
read lock is held
- comments and function names have been revised and clarified
---
Chuck Lever (13):
NFSD: Pass the target nfsd_file to nfsd_commit()
NFSD: Revert "NFSD: NFSv4 CLOSE should release an nfsd_file immediately"
NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collection
NFSD: Clean up nfs4_preprocess_stateid_op() call sites
NFSD: Trace delegation revocations
NFSD: Use const pointers as parameters to fh_ helpers
NFSD: Update file_hashtbl() helpers
NFSD: Clean up nfsd4_init_file()
NFSD: Add a remove_nfs4_file() helper
NFSD: Clean up find_or_add_file()
NFSD: Refactor find_file()
NFSD: Allocate an rhashtable for nfs4_file objects
NFSD: Use rhashtable for managing nfs4_file objects
fs/nfsd/filecache.c | 81 +++++++++++++++--------
fs/nfsd/filecache.h | 4 +-
fs/nfsd/nfs3proc.c | 10 ++-
fs/nfsd/nfs4proc.c | 42 +++++-------
fs/nfsd/nfs4state.c | 157 +++++++++++++++++++++++---------------------
fs/nfsd/nfsfh.h | 10 +--
fs/nfsd/state.h | 5 +-
fs/nfsd/trace.h | 58 +++++++++++++++-
fs/nfsd/vfs.c | 19 ++----
fs/nfsd/vfs.h | 3 +-
10 files changed, 239 insertions(+), 150 deletions(-)
--
Chuck Lever
next reply other threads:[~2022-10-25 0:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 22:36 Chuck Lever [this message]
2022-10-24 22:36 ` [PATCH v5 01/13] NFSD: Pass the target nfsd_file to nfsd_commit() Chuck Lever
2022-10-24 22:37 ` [PATCH v5 02/13] NFSD: Revert "NFSD: NFSv4 CLOSE should release an nfsd_file immediately" Chuck Lever
2022-10-24 22:37 ` [PATCH v5 03/13] NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collection Chuck Lever
2022-10-24 22:37 ` [PATCH v5 04/13] NFSD: Clean up nfs4_preprocess_stateid_op() call sites Chuck Lever
2022-10-24 22:37 ` [PATCH v5 05/13] NFSD: Trace delegation revocations Chuck Lever
2022-10-24 22:37 ` [PATCH v5 06/13] NFSD: Use const pointers as parameters to fh_ helpers Chuck Lever
2022-10-24 22:37 ` [PATCH v5 07/13] NFSD: Update file_hashtbl() helpers Chuck Lever
2022-10-24 22:37 ` [PATCH v5 08/13] NFSD: Clean up nfsd4_init_file() Chuck Lever
2022-10-24 22:37 ` [PATCH v5 09/13] NFSD: Add a remove_nfs4_file() helper Chuck Lever
2022-10-24 22:37 ` [PATCH v5 10/13] NFSD: Clean up find_or_add_file() Chuck Lever
2022-10-24 22:38 ` [PATCH v5 11/13] NFSD: Refactor find_file() Chuck Lever
2022-10-24 23:22 ` NeilBrown
2022-10-24 22:38 ` [PATCH v5 12/13] NFSD: Allocate an rhashtable for nfs4_file objects Chuck Lever
2022-10-24 23:37 ` NeilBrown
2022-10-25 0:13 ` Chuck Lever III
2022-10-25 2:26 ` NeilBrown
2022-10-24 22:38 ` [PATCH v5 13/13] NFSD: Use rhashtable for managing " Chuck Lever
2022-10-24 23:43 ` NeilBrown
2022-10-25 0:19 ` Chuck Lever III
2022-10-25 1:01 ` NeilBrown
2022-10-25 16:58 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166664935937.50761.7812494396457965637.stgit@klimt.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.