All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Kelley <mikelley@microsoft.com>
To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	tomas.winkler@intel.com, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: mikelley@microsoft.com
Subject: [PATCH 1/1] tpm/tpm_crb: Fix error message in __crb_relinquish_locality()
Date: Fri, 11 Nov 2022 11:38:53 -0800	[thread overview]
Message-ID: <1668195533-16761-1-git-send-email-mikelley@microsoft.com> (raw)

The error message in __crb_relinquish_locality() mentions requestAccess
instead of Relinquish. Fix it.

Fixes: 888d867df441 ("tpm: cmd_ready command can be issued only after granting locality")
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 drivers/char/tpm/tpm_crb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index 1860665..65f8f17 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -252,7 +252,7 @@ static int __crb_relinquish_locality(struct device *dev,
 	iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl);
 	if (!crb_wait_for_reg_32(&priv->regs_h->loc_state, mask, value,
 				 TPM2_TIMEOUT_C)) {
-		dev_warn(dev, "TPM_LOC_STATE_x.requestAccess timed out\n");
+		dev_warn(dev, "TPM_LOC_STATE_x.Relinquish timed out\n");
 		return -ETIME;
 	}
 
-- 
1.8.3.1


             reply	other threads:[~2022-11-11 19:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 19:38 Michael Kelley [this message]
2022-11-12 19:32 ` [PATCH 1/1] tpm/tpm_crb: Fix error message in __crb_relinquish_locality() Winkler, Tomas
2022-11-22 16:23   ` Michael Kelley (LINUX)
2022-11-27 16:38 ` Jarkko Sakkinen
2022-11-29  4:34   ` Michael Kelley (LINUX)
2022-12-04 19:51     ` Jarkko Sakkinen
2022-12-04 19:53       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1668195533-16761-1-git-send-email-mikelley@microsoft.com \
    --to=mikelley@microsoft.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.