From: chenxiang <chenxiang66@hisilicon.com>
To: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>,
Yihang Li <liyihang9@huawei.com>,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: [PATCH 2/2] scsi: hisi_sas: Set a port invalid only if there is no devices attached when refreshing port id
Date: Wed, 4 Jan 2023 12:03:20 +0800 [thread overview]
Message-ID: <1672805000-141102-3-git-send-email-chenxiang66@hisilicon.com> (raw)
In-Reply-To: <1672805000-141102-1-git-send-email-chenxiang66@hisilicon.com>
From: Yihang Li <liyihang9@huawei.com>
Currently it sets the port invalid if one phy in the port is not enabled,
which may cause issues in expander situation. In directly attached
situation, if phy up doesn't occur in time when refreshing port id, the
port is incorrectly set to invalid which will also cause disk lost.
Therefore set a port invalid only if there is no devices attached to the port.
Signed-off-by: Yihang Li <liyihang9@huawei.com>
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 7ce26bf..bffe4a8 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1316,7 +1316,7 @@ static void hisi_sas_refresh_port_id(struct hisi_hba *hisi_hba)
device->linkrate = phy->sas_phy.linkrate;
hisi_hba->hw->setup_itct(hisi_hba, sas_dev);
- } else
+ } else if (!port->port_attached)
port->id = 0xff;
}
}
--
2.8.1
next prev parent reply other threads:[~2023-01-04 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 4:03 [PATCH 0/2] hisi_sas: Some misc update chenxiang
2023-01-04 4:03 ` [PATCH 1/2] scsi: hisi_sas: Use abort task set to reset SAS disks when discovered chenxiang
2023-01-04 4:03 ` chenxiang [this message]
2023-01-14 3:20 ` [PATCH 0/2] hisi_sas: Some misc update Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1672805000-141102-3-git-send-email-chenxiang66@hisilicon.com \
--to=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.