All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 2/3] xfs/{080,329,434,436}: add missing check for fallocate support
Date: Tue, 17 Jan 2023 16:43:16 -0800	[thread overview]
Message-ID: <167400102773.1914975.13189675469601933878.stgit@magnolia> (raw)
In-Reply-To: <167400102747.1914975.6709564559821901777.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

Don't run this test if the filesystem doesn't support fallocate.  This
is only ever the case if always_cow is enabled.

The same logic applies to xfs/329, though it's more subtle because the
test itself does not explicitly invoke fallocate; rather, it is xfs_fsr
that requires fallocate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/080 |    1 +
 tests/xfs/329 |    1 +
 tests/xfs/434 |    1 +
 tests/xfs/436 |    1 +
 4 files changed, 4 insertions(+)


diff --git a/tests/xfs/080 b/tests/xfs/080
index 20b20a08eb..abcfa004b5 100755
--- a/tests/xfs/080
+++ b/tests/xfs/080
@@ -21,6 +21,7 @@ _cleanup()
 
 _supported_fs xfs
 _require_test
+_require_xfs_io_command falloc	# iogen requires falloc
 
 quiet=-q
 clean=-c
diff --git a/tests/xfs/329 b/tests/xfs/329
index 4cad686c17..15dc3c242f 100755
--- a/tests/xfs/329
+++ b/tests/xfs/329
@@ -22,6 +22,7 @@ _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
+_require_xfs_io_command falloc	# fsr requires support for preallocation
 
 rm -f "$seqres.full"
 
diff --git a/tests/xfs/434 b/tests/xfs/434
index 576f1b0e1e..de52531053 100755
--- a/tests/xfs/434
+++ b/tests/xfs/434
@@ -35,6 +35,7 @@ _require_quota
 _require_scratch_reflink
 _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
 
diff --git a/tests/xfs/436 b/tests/xfs/436
index 9e6ec9372d..b95da8abf4 100755
--- a/tests/xfs/436
+++ b/tests/xfs/436
@@ -30,6 +30,7 @@ _supported_fs xfs
 _require_loadable_fs_module "xfs"
 _require_scratch_reflink
 _require_cp_reflink
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt


  parent reply	other threads:[~2023-01-18  0:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  0:41 [PATCHSET 0/3] fstests: fix tests when XFS always_cow mode enabled Darrick J. Wong
2023-01-18  0:43 ` [PATCH 1/3] xfs: skip fragmentation tests when alwayscow mode is enabled Darrick J. Wong
2023-01-18  5:43   ` Christoph Hellwig
2023-01-18  0:43 ` Darrick J. Wong [this message]
2023-01-18  5:43   ` [PATCH 2/3] xfs/{080,329,434,436}: add missing check for fallocate support Christoph Hellwig
2023-01-18  0:43 ` [PATCH 3/3] various: test is not appropriate for always_cow mode Darrick J. Wong
2023-01-18  5:43   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167400102773.1914975.13189675469601933878.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.