From: Rob Herring <robh@kernel.org>
To: Fei Shao <fshao@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Jeff LaBundy <jeff@labundy.com>,
linux-kernel@vger.kernel.org,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property
Date: Thu, 27 Apr 2023 12:35:29 -0500 [thread overview]
Message-ID: <168261692866.3205353.5077242811275926416.robh@kernel.org> (raw)
In-Reply-To: <20230427035656.1962698-2-fshao@chromium.org>
On Thu, 27 Apr 2023 11:56:55 +0800, Fei Shao wrote:
> We observed that on Chromebook device Steelix, if Goodix GT7375P
> touchscreen is powered in suspend (because, for example, it connects to
> an always-on regulator) and with the reset GPIO asserted, it will
> introduce about 14mW power leakage.
>
> To address that, we add this property to skip reset during suspend.
> If it's set, the driver will stop asserting the reset GPIO during
> power-down. Refer to the comments in the driver for details.
>
> Signed-off-by: Fei Shao <fshao@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Jeff LaBundy <jeff@labundy.com>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Use a more accurate property name and with "goodix," prefix.
>
> .../devicetree/bindings/input/goodix,gt7375p.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-04-27 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 3:56 [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Fei Shao
2023-04-27 3:56 ` Fei Shao
2023-04-27 3:56 ` [PATCH v4 1/2] dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property Fei Shao
2023-04-27 3:56 ` Fei Shao
2023-04-27 17:35 ` Rob Herring [this message]
2023-04-27 3:56 ` [PATCH v4 2/2] HID: i2c-hid: goodix: Add support for " Fei Shao
2023-04-27 3:56 ` Fei Shao
2023-05-19 14:08 ` [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Doug Anderson
2023-05-23 13:11 ` Jiri Kosina
2023-05-23 13:11 ` Jiri Kosina
2023-05-23 13:32 ` Doug Anderson
2023-05-23 13:32 ` Doug Anderson
2023-05-23 15:29 ` Fei Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168261692866.3205353.5077242811275926416.robh@kernel.org \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fshao@chromium.org \
--cc=jeff@labundy.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.