All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, zlang@redhat.com
Cc: david@fromorbit.com, fstests@vger.kernel.org, guan@eryu.me,
	hch@lst.de, linux-xfs@vger.kernel.org
Subject: [GIT PULL 1/3] fstests: reload entire iunlink lists
Date: Thu, 16 Nov 2023 09:35:00 -0800	[thread overview]
Message-ID: <170015608586.3373797.8830890617259854780.stg-ugh@frogsfrogsfrogs> (raw)

Hi Zorro,

Please pull this branch with changes for fstests.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

--D

The following changes since commit 11914614784735c504f43b5b6baabaa713375984:

fstests: generic/353 should accomodate other pwrite behaviors (2023-10-27 20:19:19 +0800)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git tags/fix-iunlink-list_2023-11-16

for you to fetch changes up to 22ee90ae2da798d7462579aeb4b17d8b44671e9d:

xfs: test unlinked inode list repair on demand (2023-11-16 09:11:57 -0800)

----------------------------------------------------------------
fstests: reload entire iunlink lists [v5]

This is the second part of correcting XFS to reload the incore unlinked
inode list from the ondisk contents.  Whereas part one tackled failures
from regular filesystem calls, this part takes on the problem of needing
to reload the entire incore unlinked inode list on account of somebody
loading an inode that's in the /middle/ of an unlinked list.  This
happens during quotacheck, bulkstat, or even opening a file by handle.

In this case we don't know the length of the list that we're reloading,
so we don't want to create a new unbounded memory load while holding
resources locked.  Instead, we'll target UNTRUSTED iget calls to reload
the entire bucket.

Note that this changes the definition of the incore unlinked inode list
slightly -- i_prev_unlinked == 0 now means "not on the incore list".

v2: rebase to for-next, resend without changes
v3: add necessary prerequisites
v4: fix accidental commit to wrong patch
v5: add more review tags

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (2):
common: make helpers for ttyprintk usage
xfs: test unlinked inode list repair on demand

common/fuzzy       |   4 +-
common/rc          |  36 ++++++++-
tests/xfs/1872     | 111 +++++++++++++++++++++++++++
tests/xfs/1872.out |   5 ++
tests/xfs/1873     | 215 +++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/xfs/1873.out |   6 ++
tests/xfs/329      |   4 +-
tests/xfs/434      |   2 +-
tests/xfs/435      |   2 +-
tests/xfs/436      |   2 +-
tests/xfs/444      |   2 +-
tests/xfs/516      |   2 +-
12 files changed, 381 insertions(+), 10 deletions(-)
create mode 100755 tests/xfs/1872
create mode 100644 tests/xfs/1872.out
create mode 100755 tests/xfs/1873
create mode 100644 tests/xfs/1873.out


                 reply	other threads:[~2023-11-16 17:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170015608586.3373797.8830890617259854780.stg-ugh@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.