From: Chuck Lever <cel@kernel.org>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2 14/14] NFSD: Remove redundant cb_seq_status initialization
Date: Fri, 26 Jan 2024 12:46:38 -0500 [thread overview]
Message-ID: <170629119882.20612.2851346207930593641.stgit@manet.1015granger.net> (raw)
In-Reply-To: <170629091560.20612.563908774748586696.stgit@manet.1015granger.net>
From: Chuck Lever <chuck.lever@oracle.com>
As far as I can see, setting cb_seq_status in nfsd4_init_cb() is
superfluous because it is set again in nfsd4_cb_prepare().
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfs4callback.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index fd6a27e20f65..32dd2fbb1f30 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1450,7 +1450,6 @@ void nfsd4_init_cb(struct nfsd4_callback *cb, struct nfs4_client *clp,
cb->cb_msg.rpc_resp = cb;
cb->cb_ops = ops;
INIT_DELAYED_WORK(&cb->cb_work, nfsd4_run_cb_work);
- cb->cb_seq_status = 1;
cb->cb_status = 0;
cb->cb_need_restart = false;
cb->cb_holds_slot = false;
next prev parent reply other threads:[~2024-01-26 17:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:45 [PATCH 2 00/14] NFSD backchannel fixes Chuck Lever
2024-01-26 17:45 ` [PATCH 2 01/14] NFSD: Reset cb_seq_status after NFS4ERR_DELAY Chuck Lever
2024-01-26 17:45 ` [PATCH 2 02/14] NFSD: Convert the callback workqueue to use delayed_work Chuck Lever
2024-01-26 19:09 ` Jeff Layton
2024-01-26 17:45 ` [PATCH 2 03/14] NFSD: Reschedule CB operations when backchannel rpc_clnt is shut down Chuck Lever
2024-01-26 19:10 ` Jeff Layton
2024-01-26 17:45 ` [PATCH 2 04/14] NFSD: Retransmit callbacks after client reconnects Chuck Lever
2024-01-26 17:45 ` [PATCH 2 05/14] NFSD: Add nfsd_seq4_status trace event Chuck Lever
2024-01-26 17:45 ` [PATCH 2 06/14] NFSD: Replace dprintks in nfsd4_cb_sequence_done() Chuck Lever
2024-01-26 17:45 ` [PATCH 2 07/14] NFSD: Rename nfsd_cb_state trace point Chuck Lever
2024-01-26 17:46 ` [PATCH 2 08/14] NFSD: Add callback operation lifetime trace points Chuck Lever
2024-01-26 17:46 ` [PATCH 2 09/14] SUNRPC: Remove EXPORT_SYMBOL_GPL for svc_process_bc() Chuck Lever
2024-01-26 17:46 ` [PATCH 2 10/14] NFSD: Remove unused @reason argument Chuck Lever
2024-01-26 17:46 ` [PATCH 2 11/14] NFSD: Replace comment with lockdep assertion Chuck Lever
2024-01-26 17:46 ` [PATCH 2 12/14] NFSD: Remove BUG_ON in nfsd4_process_cb_update() Chuck Lever
2024-01-26 17:46 ` [PATCH 2 13/14] SUNRPC: Remove stale comments Chuck Lever
2024-01-26 17:46 ` Chuck Lever [this message]
2024-01-26 20:10 ` [PATCH 2 00/14] NFSD backchannel fixes Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170629119882.20612.2851346207930593641.stgit@manet.1015granger.net \
--to=cel@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.