All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
To: <chenhuacai@kernel.org>, <jonas@southpole.se>,
	<stefan.kristiansson@saunalahti.fi>, <shorne@gmail.com>,
	<ysato@users.sourceforge.jp>, <dalias@libc.org>,
	<glaubitz@physik.fu-berlin.de>, <robh+dt@kernel.org>,
	<frowand.list@gmail.com>
Cc: <linux-openrisc@vger.kernel.org>, <loongarch@lists.linux.dev>,
	<linux-sh@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <kernel@quicinc.com>,
	Oreoluwa Babatunde <quic_obabatun@quicinc.com>
Subject: [PATCH 3/3] sh: Call paging_init() earlier in the init sequence
Date: Fri, 9 Feb 2024 16:29:31 -0800	[thread overview]
Message-ID: <1707524971-146908-4-git-send-email-quic_obabatun@quicinc.com> (raw)
In-Reply-To: <1707524971-146908-1-git-send-email-quic_obabatun@quicinc.com>

The unflatten_device_tree() function contains a call to
memblock_alloc(). This is a problem because this allocation is done
before any of the reserved memory is set aside in paging_init().
This means that there is a possibility for memblock to allocate from
any of the memory regions that are supposed to be set aside as reserved.

Hence, move the call to paging_init() to be earlier in the init
sequence so that the reserved memory regions are set aside before any
allocations are done using memblock.

Signed-off-by: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
---
 arch/sh/kernel/setup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c
index d3175f0..ea40798 100644
--- a/arch/sh/kernel/setup.c
+++ b/arch/sh/kernel/setup.c
@@ -322,6 +322,8 @@ void __init setup_arch(char **cmdline_p)
 	/* Let earlyprintk output early console messages */
 	sh_early_platform_driver_probe("earlyprintk", 1, 1);
 
+	paging_init();
+
 #ifdef CONFIG_OF_EARLY_FLATTREE
 #ifdef CONFIG_USE_BUILTIN_DTB
 	unflatten_and_copy_device_tree();
@@ -330,8 +332,6 @@ void __init setup_arch(char **cmdline_p)
 #endif
 #endif
 
-	paging_init();
-
 	/* Perform the machine specific initialisation */
 	if (likely(sh_mv.mv_setup))
 		sh_mv.mv_setup(cmdline_p);
-- 

  parent reply	other threads:[~2024-02-10  0:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10  0:29 [PATCH 0/3] Restructure init sequence to set aside reserved memory earlier Oreoluwa Babatunde
2024-02-10  0:29 ` [PATCH 1/3] loongarch: Call arch_mem_init() before platform_init() in the init sequence Oreoluwa Babatunde
2024-02-14 13:03   ` Huacai Chen
2024-02-14 21:31     ` Oreoluwa Babatunde
2024-02-15  9:37       ` Huacai Chen
2024-02-10  0:29 ` [PATCH 2/3] openrisc: Call setup_memory() earlier " Oreoluwa Babatunde
2024-03-08 22:27   ` Stafford Horne
2024-02-10  0:29 ` Oreoluwa Babatunde [this message]
2024-03-11 16:02   ` [PATCH 3/3] sh: Call paging_init() " Rob Herring
2024-03-05 18:59 ` [PATCH 0/3] Restructure init sequence to set aside reserved memory earlier Oreoluwa Babatunde
2024-03-08 22:20   ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1707524971-146908-4-git-send-email-quic_obabatun@quicinc.com \
    --to=quic_obabatun@quicinc.com \
    --cc=chenhuacai@kernel.org \
    --cc=dalias@libc.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=jonas@southpole.se \
    --cc=kernel@quicinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.