All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Cedric Le Goater <clg@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Marc-Andre Lureau <marcandre.lureau@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Steve Sistare <steven.sistare@oracle.com>
Subject: [PATCH V4 07/14] migration: per-mode notifiers
Date: Thu, 22 Feb 2024 09:28:33 -0800	[thread overview]
Message-ID: <1708622920-68779-8-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1708622920-68779-1-git-send-email-steven.sistare@oracle.com>

Keep a separate list of migration notifiers for each migration mode.

Suggested-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 include/migration/misc.h |  6 ++++++
 migration/migration.c    | 22 +++++++++++++++++-----
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/include/migration/misc.h b/include/migration/misc.h
index e36a1f3..4dc06a9 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -86,6 +86,12 @@ typedef int (*MigrationNotifyFunc)(NotifierWithReturn *notify,
 void migration_add_notifier(NotifierWithReturn *notify,
                             MigrationNotifyFunc func);
 
+/*
+ * Same as migration_add_notifier, but applies to be specified @mode.
+ */
+void migration_add_notifier_mode(NotifierWithReturn *notify,
+                                 MigrationNotifyFunc func, MigMode mode);
+
 void migration_remove_notifier(NotifierWithReturn *notify);
 void migration_call_notifiers(MigrationState *s, MigrationEventType type);
 bool migration_in_setup(MigrationState *);
diff --git a/migration/migration.c b/migration/migration.c
index 33149c4..925103b 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -69,8 +69,13 @@
 #include "qemu/sockets.h"
 #include "sysemu/kvm.h"
 
-static NotifierWithReturnList migration_state_notifiers =
-    NOTIFIER_WITH_RETURN_LIST_INITIALIZER(migration_state_notifiers);
+#define NOTIFIER_ELEM_INIT(array, elem)    \
+    [elem] = NOTIFIER_WITH_RETURN_LIST_INITIALIZER((array)[elem])
+
+static NotifierWithReturnList migration_state_notifiers[] = {
+    NOTIFIER_ELEM_INIT(migration_state_notifiers, MIG_MODE_NORMAL),
+    NOTIFIER_ELEM_INIT(migration_state_notifiers, MIG_MODE_CPR_REBOOT),
+};
 
 /* Messages sent on the return path from destination to source */
 enum mig_rp_message_type {
@@ -1463,11 +1468,17 @@ static void migrate_fd_cancel(MigrationState *s)
     }
 }
 
+void migration_add_notifier_mode(NotifierWithReturn *notify,
+                                 MigrationNotifyFunc func, MigMode mode)
+{
+    notify->notify = (NotifierWithReturnFunc)func;
+    notifier_with_return_list_add(&migration_state_notifiers[mode], notify);
+}
+
 void migration_add_notifier(NotifierWithReturn *notify,
                             MigrationNotifyFunc func)
 {
-    notify->notify = (NotifierWithReturnFunc)func;
-    notifier_with_return_list_add(&migration_state_notifiers, notify);
+    migration_add_notifier_mode(notify, func, MIG_MODE_NORMAL);
 }
 
 void migration_remove_notifier(NotifierWithReturn *notify)
@@ -1480,10 +1491,11 @@ void migration_remove_notifier(NotifierWithReturn *notify)
 
 void migration_call_notifiers(MigrationState *s, MigrationEventType type)
 {
+    MigMode mode = s->parameters.mode;
     MigrationEvent e;
 
     e.type = type;
-    notifier_with_return_list_notify(&migration_state_notifiers, &e, 0);
+    notifier_with_return_list_notify(&migration_state_notifiers[mode], &e, 0);
 }
 
 bool migration_in_setup(MigrationState *s)
-- 
1.8.3.1



  parent reply	other threads:[~2024-02-22 17:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 17:28 [PATCH V4 00/14] allow cpr-reboot for vfio Steve Sistare
2024-02-22 17:28 ` [PATCH V4 01/14] notify: pass error to notifier with return Steve Sistare
2024-02-22 17:28 ` [PATCH V4 02/14] migration: remove error from notifier data Steve Sistare
2024-02-22 17:28 ` [PATCH V4 03/14] migration: convert to NotifierWithReturn Steve Sistare
2024-02-22 17:28 ` [PATCH V4 04/14] migration: MigrationEvent for notifiers Steve Sistare
2024-02-22 17:28 ` [PATCH V4 05/14] migration: remove postcopy_after_devices Steve Sistare
2024-02-22 17:28 ` [PATCH V4 06/14] migration: MigrationNotifyFunc Steve Sistare
2024-02-22 17:28 ` Steve Sistare [this message]
2024-02-22 17:28 ` [PATCH V4 08/14] migration: refactor migrate_fd_connect failures Steve Sistare
2024-02-22 17:28 ` [PATCH V4 09/14] migration: notifier error checking Steve Sistare
2024-02-26  2:03   ` Peter Xu
2024-02-22 17:28 ` [PATCH V4 10/14] migration: stop vm for cpr Steve Sistare
2024-02-26  2:08   ` Peter Xu
2024-02-29 15:21     ` Steven Sistare
2024-03-01  1:28       ` Peter Xu
2024-03-01 10:41         ` Cédric Le Goater
2024-03-13 14:18         ` Steven Sistare
2024-03-13 21:22           ` Cédric Le Goater
2024-02-22 17:28 ` [PATCH V4 11/14] vfio: register container " Steve Sistare
2024-02-29  8:35   ` Cédric Le Goater
2024-02-29 13:40     ` Steven Sistare
2024-02-22 17:28 ` [PATCH V4 12/14] vfio: allow cpr-reboot migration if suspended Steve Sistare
2024-02-29  8:44   ` Cédric Le Goater
2024-02-22 17:28 ` [PATCH V4 13/14] migration: update cpr-reboot description Steve Sistare
2024-02-26  2:10   ` Peter Xu
2024-02-28  7:12   ` Markus Armbruster
2024-02-22 17:28 ` [PATCH V4 14/14] migration: options incompatible with cpr Steve Sistare
2024-02-26  2:10   ` Peter Xu
2024-02-28  7:21   ` Markus Armbruster
2024-02-28 13:23     ` Steven Sistare
2024-02-28 16:05       ` Markus Armbruster
2024-02-28 16:31         ` Steven Sistare
2024-02-29  5:31           ` Markus Armbruster
2024-02-29  5:40             ` Peter Xu
2024-02-29 14:59               ` Steven Sistare
2024-02-22 17:33 ` [PATCH V4 00/14] allow cpr-reboot for vfio Steven Sistare
2024-02-26  2:14   ` Peter Xu
2024-02-26  8:49     ` Cédric Le Goater
2024-02-26  9:01       ` Peter Xu
2024-02-26 20:21         ` Steven Sistare
2024-02-26 22:08           ` Steven Sistare
2024-02-27  4:07             ` Peter Xu
2024-03-08 16:52   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1708622920-68779-8-git-send-email-steven.sistare@oracle.com \
    --to=steven.sistare@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=david@redhat.com \
    --cc=farosas@suse.de \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.