All of lore.kernel.org
 help / color / mirror / Atom feed
From: liwenyu <wenyuli@ex.bilibili.com>
To: akpm@linux-foundation.org
Cc: bsingharora@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, wangyun@bilibili.com
Subject: [PATCH] delayacct: add memory reclaim delay in get_page_from_freelist
Date: Wed, 20 Sep 2023 17:38:49 +0800	[thread overview]
Message-ID: <181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com> (raw)

The current memory reclaim delay statistics only count the direct memory
reclaim of the task in do_try_to_free_pages(). In systems with NUMA
open, some tasks occasionally experience slower response times, but the
total count of reclaim does not increase, using ftrace can show that
node_reclaim has occurred.

The memory reclaim occurring in get_page_from_freelist() is also due to
heavy memory load. To get the impact of tasks in memory reclaim, this
patch adds the statistics of the memory reclaim delay statistics for
__node_reclaim().

Signed-off-by: Wen Yu Li <wenyuli@ex.bilibili.com>
---
  mm/vmscan.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 6f13394b112e..88be3dedc584 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -8026,6 +8026,7 @@ static int __node_reclaim(struct pglist_data 
*pgdat, gfp_t gfp_mask, unsigned in

  	cond_resched();
  	psi_memstall_enter(&pflags);
+	delayacct_freepages_start();
  	fs_reclaim_acquire(sc.gfp_mask);
  	/*
  	 * We need to be able to allocate from the reserves for RECLAIM_UNMAP
@@ -8048,6 +8049,7 @@ static int __node_reclaim(struct pglist_data 
*pgdat, gfp_t gfp_mask, unsigned in
  	memalloc_noreclaim_restore(noreclaim_flag);
  	fs_reclaim_release(sc.gfp_mask);
  	psi_memstall_leave(&pflags);
+	delayacct_freepages_end();

  	trace_mm_vmscan_node_reclaim_end(sc.nr_reclaimed);

-- 
2.30.2


             reply	other threads:[~2023-09-20  9:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  9:38 liwenyu [this message]
2023-09-20 16:07 ` [PATCH] delayacct: add memory reclaim delay in get_page_from_freelist Andrew Morton
2023-09-25  6:43   ` liwenyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com \
    --to=wenyuli@ex.bilibili.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wangyun@bilibili.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.