From: Joe Perches <joe@perches.com> To: Andrew Morton <akpm@linux-foundation.org>, Felix Fietkau <nbd@openwrt.org>, John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>, Nelson Chang <nelson.chang@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/12] net: ethernet: mediatek: Fix misuses of GENMASK macro Date: Tue, 9 Jul 2019 22:04:20 -0700 [thread overview] Message-ID: <1961dd832a1363b6dfdbac6cb0b1c71fa838d258.1562734889.git.joe@perches.com> (raw) In-Reply-To: <cover.1562734889.git.joe@perches.com> Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 2 +- drivers/net/ethernet/mediatek/mtk_sgmii.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h index 876ce6798709..221012ecb845 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -712,7 +712,7 @@ struct mtk_soc_data { #define MTK_MAX_DEVS 2 #define MTK_SGMII_PHYSPEED_AN BIT(31) -#define MTK_SGMII_PHYSPEED_MASK GENMASK(0, 2) +#define MTK_SGMII_PHYSPEED_MASK GENMASK(2, 0) #define MTK_SGMII_PHYSPEED_1000 BIT(0) #define MTK_SGMII_PHYSPEED_2500 BIT(1) #define MTK_HAS_FLAGS(flags, _x) (((flags) & (_x)) == (_x)) diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c index 136f90ce5a65..ff509d42d818 100644 --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c @@ -82,7 +82,7 @@ int mtk_sgmii_setup_mode_force(struct mtk_sgmii *ss, int id) return -EINVAL; regmap_read(ss->regmap[id], ss->ana_rgc3, &val); - val &= ~GENMASK(2, 3); + val &= ~GENMASK(3, 2); mode = ss->flags[id] & MTK_SGMII_PHYSPEED_MASK; val |= (mode == MTK_SGMII_PHYSPEED_1000) ? 0 : BIT(2); regmap_write(ss->regmap[id], ss->ana_rgc3, val); -- 2.15.0
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Andrew Morton <akpm@linux-foundation.org>, Felix Fietkau <nbd@openwrt.org>, John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>, Nelson Chang <nelson.chang@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/12] net: ethernet: mediatek: Fix misuses of GENMASK macro Date: Tue, 9 Jul 2019 22:04:20 -0700 [thread overview] Message-ID: <1961dd832a1363b6dfdbac6cb0b1c71fa838d258.1562734889.git.joe@perches.com> (raw) In-Reply-To: <cover.1562734889.git.joe@perches.com> Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 2 +- drivers/net/ethernet/mediatek/mtk_sgmii.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h index 876ce6798709..221012ecb845 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -712,7 +712,7 @@ struct mtk_soc_data { #define MTK_MAX_DEVS 2 #define MTK_SGMII_PHYSPEED_AN BIT(31) -#define MTK_SGMII_PHYSPEED_MASK GENMASK(0, 2) +#define MTK_SGMII_PHYSPEED_MASK GENMASK(2, 0) #define MTK_SGMII_PHYSPEED_1000 BIT(0) #define MTK_SGMII_PHYSPEED_2500 BIT(1) #define MTK_HAS_FLAGS(flags, _x) (((flags) & (_x)) == (_x)) diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c index 136f90ce5a65..ff509d42d818 100644 --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c @@ -82,7 +82,7 @@ int mtk_sgmii_setup_mode_force(struct mtk_sgmii *ss, int id) return -EINVAL; regmap_read(ss->regmap[id], ss->ana_rgc3, &val); - val &= ~GENMASK(2, 3); + val &= ~GENMASK(3, 2); mode = ss->flags[id] & MTK_SGMII_PHYSPEED_MASK; val |= (mode == MTK_SGMII_PHYSPEED_1000) ? 0 : BIT(2); regmap_write(ss->regmap[id], ss->ana_rgc3, val); -- 2.15.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-10 5:04 UTC|newest] Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20190710050444epcas1p250f7aa0f8798a7757df51d66f5970c2a@epcas1p2.samsung.com> 2019-07-10 5:04 ` [PATCH 00/12] treewide: Fix GENMASK misuses Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` [PATCH 01/12] checkpatch: Add GENMASK tests Joe Perches 2019-07-24 18:03 ` Joe Perches 2019-07-10 5:04 ` [PATCH 02/12] clocksource/drivers/npcm: Fix misuse of GENMASK macro Joe Perches 2019-07-10 9:10 ` [tip:timers/urgent] " tip-bot for Joe Perches 2019-07-15 10:00 ` [PATCH 02/12] " Avi Fishman 2019-07-15 10:00 ` Avi Fishman 2019-07-10 5:04 ` [PATCH 03/12] drm: aspeed_gfx: " Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-24 17:16 ` Joe Perches 2019-07-24 17:16 ` Joe Perches 2019-07-25 1:10 ` Andrew Jeffery 2019-07-25 1:10 ` Andrew Jeffery 2019-07-25 1:10 ` Andrew Jeffery 2019-07-25 1:18 ` Joe Perches 2019-07-25 1:18 ` Joe Perches 2019-07-25 1:18 ` Joe Perches 2019-07-25 2:52 ` Joel Stanley 2019-07-25 2:52 ` Joel Stanley 2019-07-25 14:37 ` Joe Perches 2019-07-25 14:37 ` Joe Perches 2019-07-25 14:37 ` Joe Perches 2019-07-10 5:04 ` [PATCH 04/12] iio: adc: max9611: " Joe Perches 2019-07-14 11:54 ` Jonathan Cameron 2019-07-14 12:19 ` Joe Perches 2019-07-14 14:37 ` Jacopo Mondi 2019-07-29 21:52 ` Jacopo Mondi 2019-07-31 8:37 ` Jonathan Cameron 2019-07-10 5:04 ` [PATCH 05/12] irqchip/gic-v3-its: " Joe Perches 2019-07-10 8:28 ` Marc Zyngier 2019-07-10 9:07 ` [tip:irq/urgent] " tip-bot for Joe Perches 2019-07-10 5:04 ` [PATCH 06/12] mmc: meson-mx-sdio: " Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-22 7:23 ` Neil Armstrong 2019-07-22 7:23 ` Neil Armstrong 2019-07-22 7:23 ` Neil Armstrong 2019-07-22 13:43 ` Ulf Hansson 2019-07-22 13:43 ` Ulf Hansson 2019-07-22 13:43 ` Ulf Hansson 2019-07-10 5:04 ` Joe Perches [this message] 2019-07-10 5:04 ` [PATCH 07/12] net: ethernet: mediatek: Fix misuses " Joe Perches 2019-07-10 5:04 ` [PATCH 08/12] net: stmmac: " Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 10:33 ` Jose Abreu 2019-07-10 10:33 ` Jose Abreu 2019-07-10 5:04 ` [PATCH 09/12] rtw88: Fix misuse " Joe Perches 2019-07-10 5:07 ` Tony Chuang 2019-07-24 11:48 ` Kalle Valo 2019-07-10 5:04 ` [PATCH 10/12] phy: amlogic: G12A: " Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-22 7:23 ` Neil Armstrong 2019-07-22 7:23 ` Neil Armstrong 2019-07-22 7:23 ` Neil Armstrong 2019-08-23 2:41 ` Kishon Vijay Abraham I 2019-08-23 2:41 ` Kishon Vijay Abraham I 2019-08-23 2:41 ` Kishon Vijay Abraham I 2019-08-23 4:59 ` Joe Perches 2019-08-23 4:59 ` Joe Perches 2019-08-23 4:59 ` Joe Perches 2019-07-10 5:04 ` [PATCH 11/12] staging: media: cedrus: " Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` Joe Perches 2019-07-10 7:23 ` Paul Kocialkowski 2019-07-10 7:23 ` Paul Kocialkowski 2019-07-10 7:23 ` Paul Kocialkowski 2019-07-24 17:09 ` Joe Perches 2019-07-24 17:09 ` Joe Perches 2019-07-24 18:35 ` Greg Kroah-Hartman 2019-07-24 18:35 ` Greg Kroah-Hartman 2019-07-24 18:39 ` Joe Perches 2019-07-24 18:39 ` Joe Perches 2019-07-24 18:55 ` Greg Kroah-Hartman 2019-07-24 18:55 ` Greg Kroah-Hartman 2019-07-25 6:46 ` Hans Verkuil 2019-07-25 6:46 ` Hans Verkuil 2019-07-10 5:04 ` Joe Perches 2019-07-10 5:04 ` [PATCH 12/12] ASoC: wcd9335: " Joe Perches 2019-07-22 12:22 ` Applied "ASoC: wcd9335: Fix misuse of GENMASK macro" to the asoc tree Mark Brown 2019-07-22 12:22 ` Mark Brown 2019-07-10 9:17 ` [PATCH 00/12] treewide: Fix GENMASK misuses Johannes Berg 2019-07-10 9:17 ` Johannes Berg 2019-07-10 9:17 ` Johannes Berg 2019-07-10 9:17 ` Johannes Berg 2019-07-10 9:17 ` Johannes Berg 2019-07-10 9:43 ` Russell King - ARM Linux admin 2019-07-10 9:43 ` Russell King - ARM Linux admin 2019-07-10 9:43 ` Russell King - ARM Linux admin 2019-07-10 9:43 ` Russell King - ARM Linux admin 2019-07-10 9:43 ` Russell King - ARM Linux admin 2019-07-10 15:45 ` Joe Perches 2019-07-10 15:45 ` Joe Perches 2019-07-10 15:45 ` Joe Perches 2019-07-10 15:45 ` Joe Perches 2019-07-10 15:45 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-10 16:01 ` Joe Perches 2019-07-27 19:54 ` Rikard Falkeborn 2019-07-28 23:45 ` Joe Perches 2019-07-31 19:03 ` [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn 2019-07-31 19:27 ` Joe Perches 2019-08-01 23:03 ` Rikard Falkeborn 2019-08-02 1:40 ` Masahiro Yamada 2019-08-02 3:13 ` Joe Perches 2019-08-02 3:25 ` Masahiro Yamada 2019-08-02 18:18 ` Rikard Falkeborn 2019-08-03 3:03 ` Masahiro Yamada 2019-08-03 3:12 ` Masahiro Yamada 2019-08-03 18:36 ` Rikard Falkeborn 2019-08-04 6:45 ` Masahiro Yamada 2019-08-05 19:55 ` Rikard Falkeborn 2019-08-06 15:19 ` Masahiro Yamada 2019-08-06 19:27 ` Rikard Falkeborn 2019-08-06 21:15 ` Joe Perches 2019-08-07 20:53 ` Rikard Falkeborn 2019-08-01 2:50 ` Masahiro Yamada 2019-08-01 2:57 ` Joe Perches 2019-08-01 23:03 ` Rikard Falkeborn 2019-08-01 23:03 ` [PATCH v2 1/2] linux/bits.h: Clarify macro argument names Rikard Falkeborn 2019-08-01 23:03 ` [PATCH v2 2/2] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn 2019-08-01 23:14 ` Joe Perches 2019-08-07 14:27 ` Guenter Roeck 2019-08-07 14:55 ` Masahiro Yamada 2019-08-07 16:52 ` Guenter Roeck 2019-08-07 20:07 ` Rikard Falkeborn 2019-08-08 0:07 ` Joe Perches 2019-08-08 0:58 ` Guenter Roeck 2019-08-08 1:08 ` Joe Perches 2019-08-08 1:53 ` Guenter Roeck 2019-08-08 2:44 ` kbuild test robot 2019-08-08 2:44 ` kbuild test robot 2019-08-08 3:46 ` [PATCH v2 1/2] linux/bits.h: Clarify macro argument names Masahiro Yamada 2019-08-10 18:43 ` Rikard Falkeborn 2019-08-10 19:20 ` Joe Perches 2019-08-11 18:49 ` [PATCH v3 0/3] Add compile time sanity check of GENMASK inputs Rikard Falkeborn 2019-08-11 18:49 ` [PATCH v3 1/3] x86/boot: Use common BUILD_BUG_ON Rikard Falkeborn 2019-08-12 18:19 ` [tip:x86/boot] " tip-bot for Rikard Falkeborn 2019-08-16 12:19 ` tip-bot for Rikard Falkeborn 2019-08-11 18:49 ` [PATCH v3 2/3] linux/build_bug.h: Change type to int Rikard Falkeborn 2019-10-06 2:26 ` Masahiro Yamada 2019-08-11 18:49 ` [PATCH v3 3/3] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn 2019-10-06 2:30 ` Masahiro Yamada 2019-10-08 7:23 ` Geert Uytterhoeven 2019-10-08 7:44 ` Masahiro Yamada 2019-10-08 7:52 ` Masahiro Yamada 2019-10-08 19:06 ` Rikard Falkeborn 2019-08-12 17:58 ` [PATCH v3 0/3] " Kees Cook 2019-10-05 19:46 ` Rikard Falkeborn 2019-10-09 21:45 ` [Patch v4 0/2] " Rikard Falkeborn 2019-10-09 21:45 ` [Patch v4 1/2] linux/build_bug.h: Change type to int Rikard Falkeborn 2019-10-09 21:45 ` [Patch v4 2/2] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn 2019-10-10 2:24 ` Masahiro Yamada 2019-10-12 2:27 ` Andrew Morton 2019-10-22 19:53 ` Rikard Falkeborn 2019-11-01 21:28 ` Rikard Falkeborn 2020-03-08 19:39 ` [PATCH v5] " Rikard Falkeborn 2020-03-09 16:40 ` Kees Cook 2019-07-11 21:30 ` [PATCH 00/12] treewide: Fix GENMASK misuses David Miller 2019-07-11 21:30 ` David Miller 2019-07-11 21:30 ` David Miller 2019-07-11 21:30 ` David Miller 2019-07-12 12:54 ` Andrzej Hajda 2019-07-12 12:54 ` Andrzej Hajda 2019-07-12 12:54 ` Andrzej Hajda 2019-07-12 12:54 ` Andrzej Hajda 2019-07-12 12:54 ` Andrzej Hajda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1961dd832a1363b6dfdbac6cb0b1c71fa838d258.1562734889.git.joe@perches.com \ --to=joe@perches.com \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=john@phrozen.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=nbd@openwrt.org \ --cc=nelson.chang@mediatek.com \ --cc=netdev@vger.kernel.org \ --cc=sean.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.