From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Joe Perches" <joe@perches.com> Cc: Gustavo Padovan <gustavo@padovan.org>, Sean Paul <seanpaul@chromium.org>, David Airlie <airlied@linux.ie>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Date: Thu, 15 Mar 2018 15:04:52 +0100 [thread overview] Message-ID: <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> (raw) In-Reply-To: <20180315133026.GR5453@intel.com> Op 15-03-18 om 14:30 schreef Ville Syrjälä: > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: >> drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary >> arguments that can be removed by creating separate functins. >> >> Create specific functions for these calls to reduce x86/64 defconfig >> size by ~20k. >> >> Modify the existing macros to use the specific calls. >> >> new: >> $ size -t drivers/gpu/drm/built-in.a | tail -1 >> 1876562 44542 995 1922099 1d5433 (TOTALS) >> >> old: >> $ size -t drivers/gpu/drm/built-in.a | tail -1 >> 1897565 44542 995 1943102 1da63e (TOTALS) >> >> Miscellanea: >> >> o intel_display requires a change to use the specific calls. > How much would we lose if we move the (drm_debug&FOO) outside the > functions again? I'm somewhat concerned about all the function call > overhead when debugs aren't even enabled. Upstream: text data bss dec hex filename 377143 5689 4352 387184 5e870 drivers/gpu/drm/drm.ko With this patch: 373831 5689 4352 383872 5db80 drivers/gpu/drm/drm.ko Moving the if outside (below): 377629 5689 4352 387670 5ea56 drivers/gpu/drm/drm.ko Bye savings.. I don't think there are any places in which the debug output is performance sensitive, so I'm ok with not inlining. --- diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index 79abf6d5b4db..928822403a59 100644 --- a/drivers/gpu/drm/drm_print.c +++ b/drivers/gpu/drm/drm_print.c @@ -89,14 +89,11 @@ void drm_dev_printk(const struct device *dev, const char *level, } EXPORT_SYMBOL(drm_dev_printk); -void drm_dbg(unsigned int category, const char *format, ...) +void __drm_dbg(const char *format, ...) { struct va_format vaf; va_list args; - if (!(drm_debug & category)) - return; - va_start(args, format); vaf.fmt = format; vaf.va = &args; @@ -106,7 +103,7 @@ void drm_dbg(unsigned int category, const char *format, ...) va_end(args); } -EXPORT_SYMBOL(drm_dbg); +EXPORT_SYMBOL(__drm_dbg); void drm_err(const char *format, ...) { diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 3a40c5a3a5fa..2a145b97bdfc 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -200,8 +200,17 @@ __printf(6, 7) void drm_dev_printk(const struct device *dev, const char *level, unsigned int category, const char *function_name, const char *prefix, const char *format, ...); -__printf(2, 3) -void drm_dbg(unsigned int category, const char *format, ...); + +__printf(1, 2) +void __drm_dbg(const char *format, ...); + + +#define drm_dbg(category, format, ...) \ + do { \ + if (drm_debug & category) \ + __drm_dbg(format, ## __VA_ARGS__); \ + } while (0) + __printf(1, 2) void drm_err(const char *format, ...);
WARNING: multiple messages have this Message-ID (diff)
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Joe Perches" <joe@perches.com> Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Date: Thu, 15 Mar 2018 15:04:52 +0100 [thread overview] Message-ID: <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> (raw) In-Reply-To: <20180315133026.GR5453@intel.com> Op 15-03-18 om 14:30 schreef Ville Syrjälä: > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: >> drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary >> arguments that can be removed by creating separate functins. >> >> Create specific functions for these calls to reduce x86/64 defconfig >> size by ~20k. >> >> Modify the existing macros to use the specific calls. >> >> new: >> $ size -t drivers/gpu/drm/built-in.a | tail -1 >> 1876562 44542 995 1922099 1d5433 (TOTALS) >> >> old: >> $ size -t drivers/gpu/drm/built-in.a | tail -1 >> 1897565 44542 995 1943102 1da63e (TOTALS) >> >> Miscellanea: >> >> o intel_display requires a change to use the specific calls. > How much would we lose if we move the (drm_debug&FOO) outside the > functions again? I'm somewhat concerned about all the function call > overhead when debugs aren't even enabled. Upstream: text data bss dec hex filename 377143 5689 4352 387184 5e870 drivers/gpu/drm/drm.ko With this patch: 373831 5689 4352 383872 5db80 drivers/gpu/drm/drm.ko Moving the if outside (below): 377629 5689 4352 387670 5ea56 drivers/gpu/drm/drm.ko Bye savings.. I don't think there are any places in which the debug output is performance sensitive, so I'm ok with not inlining. --- diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index 79abf6d5b4db..928822403a59 100644 --- a/drivers/gpu/drm/drm_print.c +++ b/drivers/gpu/drm/drm_print.c @@ -89,14 +89,11 @@ void drm_dev_printk(const struct device *dev, const char *level, } EXPORT_SYMBOL(drm_dev_printk); -void drm_dbg(unsigned int category, const char *format, ...) +void __drm_dbg(const char *format, ...) { struct va_format vaf; va_list args; - if (!(drm_debug & category)) - return; - va_start(args, format); vaf.fmt = format; vaf.va = &args; @@ -106,7 +103,7 @@ void drm_dbg(unsigned int category, const char *format, ...) va_end(args); } -EXPORT_SYMBOL(drm_dbg); +EXPORT_SYMBOL(__drm_dbg); void drm_err(const char *format, ...) { diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 3a40c5a3a5fa..2a145b97bdfc 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -200,8 +200,17 @@ __printf(6, 7) void drm_dev_printk(const struct device *dev, const char *level, unsigned int category, const char *function_name, const char *prefix, const char *format, ...); -__printf(2, 3) -void drm_dbg(unsigned int category, const char *format, ...); + +__printf(1, 2) +void __drm_dbg(const char *format, ...); + + +#define drm_dbg(category, format, ...) \ + do { \ + if (drm_debug & category) \ + __drm_dbg(format, ## __VA_ARGS__); \ + } while (0) + __printf(1, 2) void drm_err(const char *format, ...); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-15 14:04 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-13 22:02 [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Joe Perches 2018-03-13 23:33 ` ✓ Fi.CI.BAT: success for " Patchwork 2018-03-14 2:16 ` ✓ Fi.CI.IGT: " Patchwork 2018-03-15 13:22 ` [PATCH] " Maarten Lankhorst 2018-03-15 13:22 ` Maarten Lankhorst 2018-03-15 14:48 ` Joe Perches 2018-03-15 14:48 ` Joe Perches 2018-03-15 13:30 ` Ville Syrjälä 2018-03-15 13:30 ` Ville Syrjälä 2018-03-15 14:04 ` Maarten Lankhorst [this message] 2018-03-15 14:04 ` Maarten Lankhorst 2018-03-15 15:05 ` Ville Syrjälä 2018-03-15 15:05 ` Ville Syrjälä 2018-03-15 15:17 ` Joe Perches 2018-03-15 15:37 ` Ville Syrjälä 2018-03-15 15:37 ` Ville Syrjälä 2018-03-15 15:44 ` Joe Perches 2018-03-15 15:44 ` Joe Perches 2018-03-15 16:14 ` Ville Syrjälä 2018-03-15 16:14 ` Ville Syrjälä 2018-03-15 16:29 ` Joe Perches 2018-03-15 16:29 ` Joe Perches 2018-03-16 7:41 ` Daniel Vetter 2018-03-16 7:41 ` Daniel Vetter 2018-03-16 12:29 ` Joe Perches 2018-03-19 13:53 ` Daniel Vetter 2018-03-19 13:53 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com \ --to=maarten.lankhorst@linux.intel.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=gustavo@padovan.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joe@perches.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=seanpaul@chromium.org \ --cc=ville.syrjala@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.