All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Champagne <lafeuil@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>,
	Anders Blomdell <anders.blomdell@control.lth.se>
Cc: "Erik Andrén" <erik.andren@gmail.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Thomas Kaiser" <v4l@kaiser-linux.li>,
	"Linux Media" <linux-media@vger.kernel.org>,
	"Richard Case" <rich@racitup.com>
Subject: Re: topro 6800 driver
Date: Mon, 20 Apr 2009 17:37:55 +0200	[thread overview]
Message-ID: <1d4c7fd50904200837pe4c82bfx1f0638072efba919@mail.gmail.com> (raw)
In-Reply-To: <20090405193625.57c3b1fd@free.fr>

Hello Anders

I found a small time for testing your code. But your code doesn't work
with my webcam. :-(
I think it doesn't have the same sensor. Can you add in the sd_init
method the check of the sensor id ? You can adjust this patch with
your sensor id :
diff -r 5a9a52f1277e linux/drivers/media/video/gspca/tp6800.c
--- a/linux/drivers/media/video/gspca/tp6800.c	Sat Apr 18 18:21:49 2009 +0200
+++ b/linux/drivers/media/video/gspca/tp6800.c	Mon Apr 20 17:33:15 2009 +0200
@@ -1601,8 +1601,21 @@
 /* this function is called at probe and resume time */
 static int sd_init(struct gspca_dev *gspca_dev)
 {
+	int res = 0;
+	__u8 value;
+
 	/* check if the device responds */
+	REG_W(gspca_dev, TP6800_SIF_TYPE, 0x01);
+	REG_W(gspca_dev, TP6800_SIF_CONTROL, 0x01);
+	REG_W(gspca_dev, TP6800_GPIO_IO, 0x9f);
+	REG_R(gspca_dev, TP6800_GPIO_DATA, &value);
+	if ((value & 7) != 0x00) {
+		PDEBUG(D_ERR, "init reg: 0x%02x. Unrecognized sensor.", value);
+		return -1;
+	}
 	return 0;
+out:
+	return res;
 }

 /* -- start the camera -- */



Please, tell me what is your sensor id.

Thomas

  reply	other threads:[~2009-04-20 15:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 18:06 topro 6800 driver Andy Shevchenko
     [not found] ` <49CD2868.9080502@kaiser-linux.li>
     [not found]   ` <5ec8ebd50903311144h316c7e3bmd30ce2c3d5a268ee@mail.gmail.com>
     [not found]     ` <49D4EAB2.4090206@control.lth.se>
2009-04-03 20:07       ` Anders Blomdell
2009-04-03 20:54         ` Erik Andrén
2009-04-04 11:29           ` Anders Blomdell
2009-04-05 17:36             ` Jean-Francois Moine
2009-04-20 15:37               ` Thomas Champagne [this message]
     [not found]       ` <5ec8ebd50904050933w660c130wd31b1d46a53884df@mail.gmail.com>
2009-04-05 18:16         ` Fwd: " Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2009-02-27 22:15 Topro " Anders Blomdell
2009-02-28 10:31 ` Jean-Francois Moine
2009-02-28 15:11   ` Anders Blomdell
2009-02-28 15:54     ` Thomas Kaiser
2009-03-01  7:26     ` Jean-Francois Moine
2009-03-01 16:33     ` Thomas Champagne
2009-03-02 13:20       ` Jean-Francois Moine
2009-03-02 16:58         ` Anders Blomdell
2009-02-28 11:54 ` Thomas Kaiser
     [not found] ` <49B194A7.4030808@kaiser-linux.li>
2009-03-09 12:10   ` Anders Blomdell
     [not found]     ` <49B50E16.8080703@kaiser-linux.li>
2009-03-09 14:06       ` Anders Blomdell
2009-03-09 18:51       ` Anders Blomdell
2009-03-09 20:10         ` Thomas Kaiser
2009-03-09 20:29           ` Anders Blomdell
2009-03-09 20:43             ` Thomas Kaiser
     [not found]               ` <49B62023.2090206@control.lth.se>
     [not found]                 ` <49B65BA7.6070700@kaiser-linux.li>
     [not found]                   ` <49B68F34.60802@control.lth.se>
     [not found]                     ` <49B6A495.9060204@kaiser-linux.li>
2009-03-11 15:09                       ` Anders Blomdell
2009-03-11 19:11                         ` Thomas Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d4c7fd50904200837pe4c82bfx1f0638072efba919@mail.gmail.com \
    --to=lafeuil@gmail.com \
    --cc=anders.blomdell@control.lth.se \
    --cc=andy.shevchenko@gmail.com \
    --cc=erik.andren@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=rich@racitup.com \
    --cc=v4l@kaiser-linux.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.