From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v2 1/2] x86/IRQ: drop three unused variables
Date: Mon, 23 Nov 2020 16:01:53 +0100 [thread overview]
Message-ID: <1f4956f8-1d84-b7e1-65ab-d6b78b178a02@suse.com> (raw)
In-Reply-To: <935d31ab-cb65-02d7-a624-d5e047316389@suse.com>
I didn't bother figuring which commit(s) should have deleted them while
removing their last uses.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Yet one more.
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1402,7 +1402,6 @@ void desc_guest_eoi(struct irq_desc *des
{
irq_guest_action_t *action;
cpumask_t cpu_eoi_map;
- int irq;
if ( !(desc->status & IRQ_GUEST) )
{
@@ -1411,7 +1410,6 @@ void desc_guest_eoi(struct irq_desc *des
}
action = (irq_guest_action_t *)desc->action;
- irq = desc - irq_desc;
if ( unlikely(!test_and_clear_bool(pirq->masked)) ||
unlikely(--action->in_flight != 0) )
@@ -1531,7 +1529,6 @@ int pirq_shared(struct domain *d, int pi
int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
{
- unsigned int irq;
struct irq_desc *desc;
irq_guest_action_t *action, *newaction = NULL;
int rc = 0;
@@ -1548,7 +1545,6 @@ int pirq_guest_bind(struct vcpu *v, stru
}
action = (irq_guest_action_t *)desc->action;
- irq = desc - irq_desc;
if ( !(desc->status & IRQ_GUEST) )
{
@@ -1663,13 +1659,11 @@ int pirq_guest_bind(struct vcpu *v, stru
static irq_guest_action_t *__pirq_guest_unbind(
struct domain *d, struct pirq *pirq, struct irq_desc *desc)
{
- unsigned int irq;
irq_guest_action_t *action;
cpumask_t cpu_eoi_map;
int i;
action = (irq_guest_action_t *)desc->action;
- irq = desc - irq_desc;
if ( unlikely(action == NULL) )
{
next prev parent reply other threads:[~2020-11-23 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:00 [PATCH v2 0/2] x86/IRQ: a little bit of tidying Jan Beulich
2020-11-23 15:01 ` Jan Beulich [this message]
2020-11-23 15:02 ` [PATCH v2 2/2] x86/IRQ: reduce casting involved in guest action retrieval Jan Beulich
2020-12-04 11:40 ` [PATCH v2 0/2] x86/IRQ: a little bit of tidying Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4956f8-1d84-b7e1-65ab-d6b78b178a02@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.