All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew de Quincey <adq_dvb@lidskialf.net>
To: linux-omap@vger.kernel.org
Subject: Patch: Fix N770 MMC support
Date: Sat, 23 May 2009 17:49:39 +0100	[thread overview]
Message-ID: <20090523174939.45129s043kunkc2o@lidskialf.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Some of the N770's MMC configuration options seem to have been  
dropped. This patch adds them back in again.

Note that only the .ocr_mask change was /critical/, but I've added the  
.max_freq setting back as well, as the original sources had it. Can  
anyone confirm if this is unnecessary?

Secondly, there is support in the original code for a 4wire/higher  
speed mode. As I don't have the requisite N770 hardware (I think it  
was a rev2 N770?) to test this, I can't really add it back.


[-- Attachment #2: fix-n770-mmc.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

commit b67345993d494a1dd5021e29de9611af80cbf1cd
Author: Andrew de Quincey <adq@lidskialf.net>
Date:   Sat May 23 17:43:19 2009 +0100

    Fix n770 MMC support
    
    Some of the necessary configuration settings for the N770's MMC support had been
    dropped. Add them back in again.
    
    Signed-off-by: Andrew de Quincey <adq@lidskialf.net>

diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c
index 2c4785e..bfed959 100644
--- a/arch/arm/mach-omap1/board-nokia770.c
+++ b/arch/arm/mach-omap1/board-nokia770.c
@@ -209,9 +209,11 @@ static int nokia770_mmc_get_cover_state(struct device *dev, int slot)
 static struct omap_mmc_platform_data nokia770_mmc2_data = {
 	.nr_slots                       = 1,
 	.dma_mask			= 0xffffffff,
+	.max_freq                       = 12000000,
 	.slots[0]       = {
 		.set_power		= nokia770_mmc_set_power,
 		.get_cover_state	= nokia770_mmc_get_cover_state,
+		.ocr_mask               = MMC_VDD_32_33|MMC_VDD_33_34,
 		.name                   = "mmcblk",
 	},
 };

             reply	other threads:[~2009-05-23 16:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 16:49 Andrew de Quincey [this message]
2009-06-01 23:09 ` [APPLIED] Patch: Fix N770 MMC support Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090523174939.45129s043kunkc2o@lidskialf.net \
    --to=adq_dvb@lidskialf.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.