All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew de Quincey <adq_dvb@lidskialf.net>
To: linux-omap@vger.kernel.org
Subject: Patch: Fix N770 brf6150 bluetooth driver
Date: Sat, 23 May 2009 18:42:08 +0100	[thread overview]
Message-ID: <20090523184208.14202m390hgqxv28@lidskialf.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

This driver has the same problem as the cbus drivers - mismatch  
between platform_device and non-platform driver APIs.

Switching it to use platform_driver removes the random corruption and  
badness I was seeing on boot.


[-- Attachment #2: fix-brf6150.patch --]
[-- Type: text/x-patch, Size: 1625 bytes --]

commit e6dce93304c6c692e187b95eaea227cfe3cb3317
Author: Andrew de Quincey <adq@lidskialf.net>
Date:   Sat May 23 18:37:25 2009 +0100

    Fix brf6150.c platform_device breakage
    
    This driver has the mismatch between platform_devices and non-platform drivers.
    Switch it to use platform_driver as well.
    
    Signed-off-by: Andrew de Quincey <adq@lidskialf.net>

diff --git a/drivers/bluetooth/brf6150.c b/drivers/bluetooth/brf6150.c
index 211fa5e..f29caf5 100644
--- a/drivers/bluetooth/brf6150.c
+++ b/drivers/bluetooth/brf6150.c
@@ -90,9 +90,10 @@ static struct platform_device brf6150_device = {
 	}
 };
 
-static struct device_driver brf6150_driver = {
-	.name		= BT_DRIVER,
-	.bus		= &platform_bus_type,
+static struct platform_driver brf6150_driver = {
+	.driver = {
+		.name		= BT_DRIVER,
+	}
 };
 
 static inline void brf6150_outb(struct brf6150_info *info, unsigned int offset, u8 val)
@@ -1002,7 +1003,7 @@ static int __init brf6150_init(void)
 		goto cleanup_irq;
 	}
 	/* Register the driver with LDM */
-	if (driver_register(&brf6150_driver)) {
+	if (platform_driver_register(&brf6150_driver)) {
 		printk(KERN_WARNING "failed to register brf6150 driver\n");
 		platform_device_unregister(&brf6150_device);
 		err = -ENODEV;
@@ -1012,7 +1013,7 @@ static int __init brf6150_init(void)
 	if (brf6150_register_hdev(info) < 0) {
 		printk(KERN_WARNING "failed to register brf6150 hci device\n");
 		platform_device_unregister(&brf6150_device);
-		driver_unregister(&brf6150_driver);
+		platform_driver_unregister(&brf6150_driver);
 		goto cleanup_irq;
 	}
 

             reply	other threads:[~2009-05-23 17:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 17:42 Andrew de Quincey [this message]
2009-06-01 23:13 ` [APPLIED] Patch: Fix N770 brf6150 bluetooth driver Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090523184208.14202m390hgqxv28@lidskialf.net \
    --to=adq_dvb@lidskialf.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.