All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>, avi@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	mtosatti@redhat.com, paulmck@linux.vnet.ibm.com,
	markmc@redhat.com
Subject: Re: [PATCHv3 4/4] kvm: remove in_range from io devices
Date: Mon, 29 Jun 2009 15:20:04 +0300	[thread overview]
Message-ID: <20090629122004.GA21640@redhat.com> (raw)
In-Reply-To: <20090629120919.GE21273@redhat.com>

On Mon, Jun 29, 2009 at 03:09:19PM +0300, Michael S. Tsirkin wrote:
> This changes bus accesses to use high-level kvm_io_bus_read/kvm_io_bus_write
> functions. in_range now becomes unused so it is removed from device ops in
> favor of read/write callbacks performing range checks internally.
> 
> This allows aliasing (mostly for in-kernel virtio), as well as better error
> handling by making it possible to pass errors up to userspace.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Ugh, forgot this trivial typo fix. Sorry.

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 790bd55..82e76da 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2276,7 +2276,7 @@ static int vcpu_mmio_read(struct kvm_vcpu *vcpu, gpa_t addr, int len, void *v)
 	    !kvm_iodevice_read(&vcpu->arch.apic->dev, addr, len, v))
 		return 0;
 
-	return kvm_io_bus_read(vcpu->kvm, &vcpu->kvm->mmio_bus, addr, len, v);
+	return kvm_io_bus_read(&vcpu->kvm->mmio_bus, addr, len, v);
 }
 
 static int kvm_read_guest_virt(gva_t addr, void *val, unsigned int bytes,

      reply	other threads:[~2009-06-29 12:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1246276816.git.mst@redhat.com>
2009-06-29 12:08 ` [PATCHv3 1/4] kvm: document locking for kvm_io_device_ops Michael S. Tsirkin
2009-06-29 12:09 ` [PATCHv3 2/4] kvm: switch coalesced mmio changes to slots_lock Michael S. Tsirkin
2009-06-29 12:09 ` [PATCHv3 3/4] kvm: convert bus " Michael S. Tsirkin
2009-06-29 15:50   ` Marcelo Tosatti
2009-06-29 16:38     ` Michael S. Tsirkin
2009-06-29 17:04       ` Marcelo Tosatti
2009-06-29 12:09 ` [PATCHv3 4/4] kvm: remove in_range from io devices Michael S. Tsirkin
2009-06-29 12:20   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090629122004.GA21640@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=ghaskins@novell.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.