From: Nikanth Karthikesan <knikanth@suse.de>
To: jens.axboe@oracle.com
Cc: Hannes Reinecke <hare@suse.de>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
"device-mapper development" <dm-devel@redhat.com>
Subject: [RESEND][PATCH] Send uevents for disk write_protect changes
Date: Tue, 21 Jul 2009 11:28:07 +0530 [thread overview]
Message-ID: <200907211128.07252.knikanth@suse.de> (raw)
Hi
This patch is needed for the dm-multipath, so that the daemon can capture the
event and reload the dm table when the read-only setting of the disk changes.
Can this be merged?
Thanks
Nikanth
From: Hannes Reinecke <hare@suse.de>
Subject: Send uevents for write_protect changes
Whenever a block device changes it's read-only attribute
notify the userspace about it.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/block/genhd.c b/block/genhd.c
index f4c64c2..b89328e 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1215,6 +1215,16 @@ void put_disk(struct gendisk *disk)
EXPORT_SYMBOL(put_disk);
+static void set_disk_ro_uevent(struct gendisk *gd, int ro)
+{
+ char event[] = "DISK_RO=1";
+ char *envp[] = { event, NULL };
+
+ if (!ro)
+ event[8] = '0';
+ kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp);
+}
+
void set_device_ro(struct block_device *bdev, int flag)
{
bdev->bd_part->policy = flag;
@@ -1227,8 +1237,12 @@ void set_disk_ro(struct gendisk *disk, int flag)
struct disk_part_iter piter;
struct hd_struct *part;
- disk_part_iter_init(&piter, disk,
- DISK_PITER_INCL_EMPTY | DISK_PITER_INCL_PART0);
+ if (disk->part0.policy != flag) {
+ set_disk_ro_uevent(disk, flag);
+ disk->part0.policy = flag;
+ }
+
+ disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY);
while ((part = disk_part_iter_next(&piter)))
part->policy = flag;
disk_part_iter_exit(&piter);
next reply other threads:[~2009-07-21 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 5:58 Nikanth Karthikesan [this message]
2009-07-21 13:39 ` [RESEND][PATCH] Send uevents for disk write_protect changes Tejun Heo
2009-07-21 13:39 ` Tejun Heo
2009-07-28 7:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907211128.07252.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.